Skip to content

Fix: update the application year to 2027#107

Merged
cuttle-fish-my merged 2 commits intomainfrom
dev
Jul 10, 2025
Merged

Fix: update the application year to 2027#107
cuttle-fish-my merged 2 commits intomainfrom
dev

Conversation

@cuttle-fish-my
Copy link
Copy Markdown
Member

No description provided.

@cuttle-fish-my cuttle-fish-my requested review from billhu0, boynextdoor-cze, caoster, Copilot and thezbm and removed request for Copilot July 10, 2025 15:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the list of available majors and extends the application year options through 2027.

  • Adds BioSci and BioTech to the majorList.
  • Increases the length of applicationYearOptions from 10 to 12 to cover years up to 2027.
Comments suppressed due to low confidence (2)

src/Data/Schemas.js:34

  • There aren’t any tests verifying the updated majorList—consider adding unit tests to ensure BioSci and BioTech are included and rendered correctly.
export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech'];

src/Data/Schemas.js:69

  • Add tests for applicationYearOptions to confirm that years up to 2027 are generated as expected, preventing regressions in future updates.
export const applicationYearOptions = Array.from({length: 12}, (_, i) => {

Comment thread src/Data/Schemas.js
}

export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA'];
export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech'];
Copy link

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider alphabetizing the majorList or documenting the intended order, as appending new entries at the end may lead to inconsistent UI ordering over time.

Suggested change
export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech'];
export const majorList = ['BioSci', 'BioTech', 'BME', 'CS', 'EE', 'IE', 'SCA'];

Copilot uses AI. Check for mistakes.
Comment thread src/Data/Schemas.js
Comment on lines +69 to 70
export const applicationYearOptions = Array.from({length: 12}, (_, i) => {
const year = 2016 + i;
Copy link

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The literals 12 and base year 2016 act as magic numbers here—extract them into named constants (e.g., START_YEAR and YEAR_COUNT) to improve readability and simplify future updates.

Suggested change
export const applicationYearOptions = Array.from({length: 12}, (_, i) => {
const year = 2016 + i;
export const applicationYearOptions = Array.from({length: YEAR_COUNT}, (_, i) => {
const year = START_YEAR + i;

Copilot uses AI. Check for mistakes.
@cuttle-fish-my cuttle-fish-my merged commit e90689b into main Jul 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants