Fix: update the application year to 2027#107
Merged
cuttle-fish-my merged 2 commits intomainfrom Jul 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the list of available majors and extends the application year options through 2027.
- Adds
BioSciandBioTechto themajorList. - Increases the length of
applicationYearOptionsfrom 10 to 12 to cover years up to 2027.
Comments suppressed due to low confidence (2)
src/Data/Schemas.js:34
- There aren’t any tests verifying the updated
majorList—consider adding unit tests to ensureBioSciandBioTechare included and rendered correctly.
export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech'];
src/Data/Schemas.js:69
- Add tests for
applicationYearOptionsto confirm that years up to 2027 are generated as expected, preventing regressions in future updates.
export const applicationYearOptions = Array.from({length: 12}, (_, i) => {
| } | ||
|
|
||
| export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA']; | ||
| export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech']; |
There was a problem hiding this comment.
[nitpick] Consider alphabetizing the majorList or documenting the intended order, as appending new entries at the end may lead to inconsistent UI ordering over time.
Suggested change
| export const majorList = ['CS', 'EE', 'IE', 'BME', 'SCA', 'BioSci', 'BioTech']; | |
| export const majorList = ['BioSci', 'BioTech', 'BME', 'CS', 'EE', 'IE', 'SCA']; |
Comment on lines
+69
to
70
| export const applicationYearOptions = Array.from({length: 12}, (_, i) => { | ||
| const year = 2016 + i; |
There was a problem hiding this comment.
The literals 12 and base year 2016 act as magic numbers here—extract them into named constants (e.g., START_YEAR and YEAR_COUNT) to improve readability and simplify future updates.
Suggested change
| export const applicationYearOptions = Array.from({length: 12}, (_, i) => { | |
| const year = 2016 + i; | |
| export const applicationYearOptions = Array.from({length: YEAR_COUNT}, (_, i) => { | |
| const year = START_YEAR + i; |
thezbm
approved these changes
Jul 10, 2025
caoster
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.