fix(builder): handle None batches in batch vectorizer flatten#748
Open
SAY-5 wants to merge 1 commit intoOpenSPG:masterfrom
Open
fix(builder): handle None batches in batch vectorizer flatten#748SAY-5 wants to merge 1 commit intoOpenSPG:masterfrom
SAY-5 wants to merge 1 commit intoOpenSPG:masterfrom
Conversation
asyncio.gather can yield None entries when avectorize fails or returns no embeddings for a batch, causing 'NoneType is not iterable' in _agenerate_dense_vectors / _agenerate_sparse_vectors. Skip None sublists when flattening so partial failures no longer abort the whole subgraph. Closes OpenSPG#747 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #747
asyncio.gathercan yieldNoneentries whenavectorizereturns nothing for a batch (e.g. transient API failure), causingTypeError: 'NoneType' object is not iterablein_agenerate_dense_vectorsand_agenerate_sparse_vectorsat the final flatten. SkipNonesublists when flattening so a single bad batch no longer aborts the whole subgraph.