Skip to content

feat(disability_registry): re-apply #1047 stabilization + version bump & changelog#270

Merged
emjay0921 merged 2 commits into
19.0from
feat/1047-disability-registry-reapply
Jul 2, 2026
Merged

feat(disability_registry): re-apply #1047 stabilization + version bump & changelog#270
emjay0921 merged 2 commits into
19.0from
feat/1047-disability-registry-reapply

Conversation

@emjay0921

Copy link
Copy Markdown
Contributor

Why is this change needed?

Re-applies the Disability Registry stabilization work (originally merged as #263, then reverted from 19.0 via #268 for re-review). This re-created PR brings the same work back with the version bump and changelog that #263 was missing, and is opened as a draft pending re-review + green CI before it re-lands.

How was the change implemented?

Changelog (19.0.3.0.0)

  • age-driven assessment type + manual override (#1050)
  • CFM 2-4 and CFM 5-17 questionnaires (#1048, #1049)
  • configurable assessment approval workflow (#1060)
  • impairment classification on its own multi-row tab (#1054)
  • assistive-device management + proxy response by assessment type (#1052, #1053)
  • registry recognition of approved assessments (#1022)

Unit tests

spp_disability_registry + spp_starter_disability_registry suites (incl. the coverage tests added in #263). CI runs both on this PR.

Related links

Re-applies #263 (reverted by #268). Umbrella: OP#1047.

@gemini-code-assist

Copy link
Copy Markdown

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.07018% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.31%. Comparing base (82c4eca) to head (7d1a8f6).
⚠️ Report is 4 commits behind head on 19.0.

Files with missing lines Patch % Lines
spp_disability_registry/models/assessment.py 72.48% 71 Missing ⚠️
..._disability_registry/models/res_config_settings.py 95.12% 2 Missing ⚠️
spp_disability_registry/models/registrant.py 95.45% 1 Missing ⚠️
spp_starter_disability_registry/__manifest__.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #270      +/-   ##
==========================================
+ Coverage   75.30%   75.31%   +0.01%     
==========================================
  Files        1096     1098       +2     
  Lines       64992    65317     +325     
==========================================
+ Hits        48939    49191     +252     
- Misses      16053    16126      +73     
Flag Coverage Δ
spp_base_common 90.26% <ø> (ø)
spp_disability_registry 83.87% <78.29%> (-7.99%) ⬇️
spp_programs 65.27% <ø> (ø)
spp_registry 86.83% <ø> (ø)
spp_security 66.66% <ø> (ø)
spp_starter_disability_registry 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spp_disability_registry/__manifest__.py 0.00% <ø> (ø)
spp_disability_registry/models/__init__.py 100.00% <100.00%> (ø)
spp_disability_registry/models/assistive_device.py 100.00% <100.00%> (ø)
spp_disability_registry/models/impairment.py 100.00% <100.00%> (ø)
spp_disability_registry/models/registrant.py 98.33% <95.45%> (-1.67%) ⬇️
spp_starter_disability_registry/__manifest__.py 0.00% <0.00%> (ø)
..._disability_registry/models/res_config_settings.py 95.12% <95.12%> (ø)
spp_disability_registry/models/assessment.py 77.74% <72.48%> (-16.94%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review July 2, 2026 10:14
@emjay0921 emjay0921 merged commit 1ba8bcc into 19.0 Jul 2, 2026
21 checks passed
@emjay0921 emjay0921 deleted the feat/1047-disability-registry-reapply branch July 2, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant