fix(security,vocabulary): port disability registry changes#87
fix(security,vocabulary): port disability registry changes#87
Conversation
…pp-modules-v2 - Add disability registry category to spp_security categories - Remove vocabulary_disability.xml from spp_vocabulary (extracted to spp_disability_registry)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ports essential changes related to disability registry and vocabulary management from openspp-modules-v2 to OpenSPP2. The primary goal is to resolve merge conflicts in a related refactoring PR, ensuring consistency and proper module separation for disability-related functionalities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new 'Disability Registry' module category in spp_security/security/categories.xml and removes the vocabulary_disability.xml entry from spp_vocabulary/__manifest__.py. A review comment notes that the new category in categories.xml is out of sequence order and should be re-positioned for better maintainability and consistency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #87 +/- ##
==========================================
+ Coverage 69.16% 69.53% +0.36%
==========================================
Files 632 672 +40
Lines 35639 37931 +2292
==========================================
+ Hits 24650 26374 +1724
- Misses 10989 11557 +568
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The file existed but was not referenced in the manifest, causing the OCA file-not-used pre-commit check to fail.
Move the Disability Registry category (sequence 76) to its correct position between Case Management (75) and Health Monitoring (77), matching the sequence-based ordering of the file.
2 participants
Why is this change needed?
These changes were made in openspp-modules-v2 but not yet ported to OpenSPP2. They are needed to resolve merge conflicts in openspp-modules-v2 PR #333 (refactor/openspp2-submodule).
How was the change implemented?
category_spp_disability(Disability Registry) category tospp_security/security/categories.xmlwith sequence 76data/vocabulary_disability.xmlfromspp_vocabulary/__manifest__.py(disability vocabulary was extracted to its own modulespp_disability_registry)New unit tests
Unit tests executed by the author
How to test manually
spp_securityand verify the Disability Registry category appears in user settingsspp_vocabularyand verify it loads without referencing the removed disability vocabulary fileRelated links