Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with image preview functionality within the system. The changes ensure that images are correctly displayed when the preview action is triggered, improving the user experience for viewing image content.
Highlights
- Image Preview Logic Refactor: The logic for previewing images has been updated to directly construct an image URL using the
/web/imageendpoint and pass afileModelobject to the file viewer, rather than relying on theAttachmentstore. - New Import: The
urlutility from@web/core/utils/urlshas been imported to facilitate the construction of dynamic image URLs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix image previews. The change modifies the JavaScript logic to use Odoo's /web/image URL for displaying images, which is a good approach. However, my review identifies two main issues with the implementation. First, there's a performance issue where file content is fetched twice for images, once unnecessarily. Second, the code incorrectly assumes any non-PDF file is an image, which could break previews for other file types. I've provided detailed comments with suggestions to address these high severity issues.
| const imageUrl = url("/web/image", { | ||
| model: resModel, | ||
| id: resId, | ||
| filename: record.name || "", | ||
| name: record.name || "", | ||
| mimetype: record.mimetype, | ||
| model_name: resModel, | ||
| url: fileUrl, | ||
| field: "content", | ||
| }); | ||
| const fileModel = { | ||
| isImage: true, | ||
| isViewable: true, | ||
| displayName: record.name, | ||
| defaultSource: imageUrl, | ||
| downloadUrl: imageUrl, | ||
| }; | ||
|
|
||
| this.fileViewer.open(attachment); | ||
| this.fileViewer.open(fileModel); |
There was a problem hiding this comment.
While this change correctly uses the /web/image URL for previews, it introduces a performance issue.
The orm.read on line 23 fetches the entire file content, which can be large. This content is then not used within this else block for image previews, as the image is fetched again via the imageUrl. This results in fetching the file content twice.
Additionally, the blob creation logic on lines 30-38 is executed for all file types, but the resulting fileUrl is only used for PDFs. For images, this is unnecessary work.
To improve performance, consider refactoring to:
- Only fetch file
contentwhen it's needed (i.e., for PDFs). For images, you can rely on the/web/imageroute. You could read thesizefield to check for file existence without fetching the content. - Move the blob creation logic (lines 30-38) inside the
ifblock for PDFs.
| const imageUrl = url("/web/image", { | ||
| model: resModel, | ||
| id: resId, | ||
| filename: record.name || "", | ||
| name: record.name || "", | ||
| mimetype: record.mimetype, | ||
| model_name: resModel, | ||
| url: fileUrl, | ||
| field: "content", | ||
| }); | ||
| const fileModel = { | ||
| isImage: true, | ||
| isViewable: true, | ||
| displayName: record.name, | ||
| defaultSource: imageUrl, | ||
| downloadUrl: imageUrl, | ||
| }; | ||
|
|
||
| this.fileViewer.open(attachment); | ||
| this.fileViewer.open(fileModel); |
There was a problem hiding this comment.
This logic assumes that any file that is not a PDF is an image by hardcoding isImage: true. This could lead to incorrect behavior or errors when trying to preview other viewable file types, such as videos or text files, that are not PDFs.
It would be more robust to check the file's mimetype to determine if it's an image before setting isImage: true.
For example:
const isImage = record.mimetype?.startsWith("image/");
if (isImage) {
// current logic for images
} else {
// handle other file types, or at least don't assume they are images.
// The previous implementation might give a hint on how to handle them,
// possibly by creating a blob URL and opening it with fileViewer for generic files.
}A complete implementation would require handling other file types, but at a minimum, you should avoid incorrectly classifying all non-PDFs as images.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 17.0 #832 +/- ##
==========================================
+ Coverage 76.13% 76.14% +0.01%
==========================================
Files 766 766
Lines 20306 20306
Branches 2504 2504
==========================================
+ Hits 15460 15463 +3
+ Misses 4302 4300 -2
+ Partials 544 543 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
Why is this change needed?
Fix the problem on previewing images
How was the change implemented?
Modified the JS:
preview_binary_field.esm.jsNew unit tests
Unit tests executed by the author
How to test manually
spp_dmseyeicon to previewRelated links