chore(STEF-2702): modernize release workflows on main#827
Merged
Conversation
- Delete broken auto-bump release.yaml (pushed directly to main, blocked by branch protection) - Delete obsolete bump_version.py script - Update python-upload-package.yaml to 'Release V3' with: - Trigger on release published + workflow_dispatch (matches v4 pattern) - Guard: only runs for v3.* tags/input - Version extraction from release tag or manual input - sed-based version injection into setup.py at build time - Concurrency group - Set setup.py version to 0.0.0 placeholder (real version injected by workflow) Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
|
bartpleiter
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize release workflows on main
Problem
The
release.yamlworkflow auto-bumped the version insetup.pyand pushed directly tomain. This is broken by branch protection rules and is an outdated pattern.Changes
.github/workflows/release.yaml.github/bump_version.py.github/workflows/python-upload-package.yamlsetup.py0.0.0Release V3 workflow details
release: published+workflow_dispatch(matches v4 pattern)v3.*tags or3.*/v3.*manual inputvprefix, applies viasedtosetup.pyHow to test
v3.4.93onmainsedand version steps will validate even if you don't want to actually publishworkflow_dispatchwith version3.4.93and verify it runsNotes
release-v4.yamlis left as-is (already uses the correct pattern, runs fromrelease/v4.0.0)