fix: Fix length mismatch bug in combiner fit#834
Merged
MvLieshout merged 1 commit intorelease/v4.0.0from Mar 12, 2026
Merged
Conversation
Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a regression in the
WeightsCombinermodel by ensuring that label indices are properly aligned with the combined dataset when additional features have fewer rows than the ensemble dataset. It also adds a targeted regression test to verify this behavior.Regression fix for label alignment:
fitmethod inlearned_weights_combiner.pyto reindexlabelsbased on the index of the combined dataset, preventing shape mismatches during sample weight computation.Testing improvements:
test_learned_weights_combiner.pyto confirm that fitting works correctly whenadditional_featureshas a shorter index than the ensemble dataset, and that no shape mismatch errors are raised.ForecastInputDataset,numpy, andpandasin the test file to support the new test case.