chore(deps)(deps): update scikit-learn requirement from <1.8,>=1.7.1 to >=1.7.1,<1.9 in /packages/openstef-models#916
Closed
dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [scikit-learn](https://github.com/scikit-learn/scikit-learn) to permit the latest version. - [Release notes](https://github.com/scikit-learn/scikit-learn/releases) - [Commits](scikit-learn/scikit-learn@1.7.1...1.8.0) --- updated-dependencies: - dependency-name: scikit-learn dependency-version: 1.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
This was referenced May 29, 2026
egordm
added a commit
that referenced
this pull request
May 29, 2026
…es (#934) ## Summary Refreshes `uv.lock` to clear **all 74 open Dependabot security advisories** (31 high / 29 medium / 14 low). Every vulnerable package is transitive (aiohttp ×18, pillow, jupyter-server, mistune, cryptography, urllib3, tornado, GitPython, nbconvert, …) and reaches a patched version within existing constraints — no ceiling-widening needed for security. Supersedes the pile of individual Dependabot PRs (#915, #916, #920–#930). ## Majors evaluated (per request) — adopted vs deferred | Major | Verdict | |---|---| | pyarrow 24, s3fs 2026, pycountry 26 | ✅ adopted — suite green | | numpy 2.4, scipy 1.17, xgboost 3.2, mlflow 3.12, pydantic 2.13 | ✅ adopted — suite green | | scoringrules 0.10, ruff 0.15 | ✅ adopted + code adapted (below) | | **pandas 3.0** | ⏸️ deferred — needs a Copy-on-Write migration (read-only-array failures in the median forecaster). Held `<3`; tracked in #935. | | **pyproject-fmt 2.12+** | ⏸️ capped `<2.12` — 2.12+ reformats all pyproject.toml (churn) and 1.3.x toml-fmt-common crashes it. | ## Code adapted to the upgrades - **scoringrules 0.10**: stricter input validation. crps test drops degenerate quantile levels 0.0/1.0 (zero pinball loss → value is 8/9); rcrps tests give one forecast row per observation (no more single-row broadcast). Expected values cross-checked by hand. - **ruff 0.15** new rules: `math.isclose` for a ratio-sum check (real float-fragility fix), integer percentile comparison in the plotter, docstring section reorder (D420), justified noqas for two intentional broad pipeline try-blocks and one exact-sentinel comparison. RUF069 ignored in tests (exact deterministic asserts), RUF067 ignored for package `__init__` logging setup. - **pandas-stubs 2.3.3** (pyright): comprehension instead of `functools.reduce(iadd)`, drop a now-unnecessary cast, add casts/ignores for stub-strictness changes. - **jupytext 1.19.3**: notebook re-sync (header metadata). ## Verification Local `poe all --check` is green except **two pre-existing, platform-specific failures** in `test_openstef4.py` (`test_fit_then_predict_returns_forecast`, `test_fit_retains_previous_model_on_insufficient_data`). These fail identically on pristine `main` on my macOS machine and **pass in CI** (main is green) — they are a local macOS/pickle quirk, unrelated to this change. Watching this PR's CI to confirm they stay green. - ✅ ruff lint + format, pyright (src, 0 errors), uv lock check, reuse, pyproject-fmt, doctests (107), notebooks-check - ✅ 936 tests pass (the 4 scoringrules tests now green) ## Test plan - [ ] CI green (especially the two openstef4 tests that fail only locally on macOS). - [ ] Confirm Dependabot security alerts drop to 0 after merge. --------- Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
egordm
added a commit
that referenced
this pull request
May 29, 2026
## Summary Adds `versioning-strategy: lockfile-only` to the uv block in `.github/dependabot.yml`. This stops the **"update X requirement from A to B" PR spam** — the per-package, per-directory PRs (e.g. #915, #916, #925–#929) that widen the declared version ranges in `pyproject.toml`. With lockfile-only, Dependabot updates only `uv.lock`; declared constraints stay put and are widened deliberately by a maintainer when adopting a new major. ## Unaffected - Security updates still fire (they bump the lockfile). - Grouping, cooldown, and the daily schedule are unchanged. - Major bumps still surface (as lockfile updates) where the range allows. ## Notes The currently-open requirement-widening Dependabot PRs are superseded by the lock refresh in #934 and can be closed. Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
Collaborator
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/pip/packages/openstef-models/scikit-learn-gte-1.7.1-and-lt-1.9
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on scikit-learn to permit the latest version.
Release notes
Sourced from scikit-learn's releases.
Commits
646da0f[cd build]4f4f283Generate changelog967dcdeSet versioncb1424bDOC Release highlights for 1.8 (#32809)5645b27🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 (#32859)6b9fb11🔒 🤖 CI Update lock files for free-threaded CI build(s) 🔒 :rob...a0f6d88🔒 🤖 CI Update lock files for array-api CI build(s) 🔒 🤖 ...c1de8fcFIX Makeget_namespacehandle pandas dataframe input (#32838)764249aFix_safe_indexingwith non integer arrays on array API inputs (#32840)eca5e0aFIX Add new default max_samples=None in Bagging estimators (#32825)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)