Conversation
… in select/include Adds a \`StripVirtualFromArgs\` utility type to the generated \`.opensaas/types.ts\` that strips virtual field keys from the select/include object before passing it to \`Prisma.*GetPayload<>\`. This prevents Prisma from trying to resolve virtual field names (which don't exist in its schema), which previously produced \`never\` that poisoned the intersection with the virtual fields type. Closes #383 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d81fb2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage Report for Core Package Coverage (./packages/core)
File CoverageNo changed files found. |
Contributor
Coverage Report for UI Package Coverage (./packages/ui)
File CoverageNo changed files found. |
Contributor
Coverage Report for CLI Package Coverage (./packages/cli)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for Auth Package Coverage (./packages/auth)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Package Coverage (./packages/storage)
File CoverageNo changed files found. |
Contributor
Coverage Report for RAG Package Coverage (./packages/rag)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage S3 Package Coverage (./packages/storage-s3)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Vercel Package Coverage (./packages/storage-vercel)
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StripVirtualFromArgs<T, VirtualKeys>utility type to the generated.opensaas/types.tsGetPayloadtype to strip virtual field keys fromTbefore passing toPrisma.*GetPayload<>, preventing Prisma from resolving unknown virtual field names asneverselect)Root cause recap:
Prisma.*GetPayload<T>returnedneverfor any field inT['select']it couldn't find in its schema. Intersectingneverwithstring(from the virtual fields type) still givesnever. Stripping virtual keys fromTbefore Prisma sees it breaks the cycle.Test plan
pnpm test src/generator/types.test.tsinpackages/cli)should use StripVirtualFromArgs in GetPayload for lists with virtual + relation fields (regression #383)passesGetPayloadfor a list with virtual fields containsStripVirtualFromArgs<T, keyof ${List}VirtualFields>instead of bareTGetPayloadfor a list without virtual fields is unchanged (still uses bareT)Closes #383
🤖 Generated with Claude Code