Skip to content

Fix project images#200

Merged
dergigi merged 6 commits into
OpenSats:masterfrom
Bayernatoor:fix_project_images
Jan 15, 2024
Merged

Fix project images#200
dergigi merged 6 commits into
OpenSats:masterfrom
Bayernatoor:fix_project_images

Conversation

@Bayernatoor
Copy link
Copy Markdown
Contributor

Fixes project image styles/responsiveness

  1. Remove deprecated props on the Image comp
  2. Modify Image comp styles
  3. Add customImageStyle prop to ProjectCard comp to style Opensat projects independently of other projects.

Small changes but makes all the images consistent and properly sized.

…or opensat project cards

Signed-off-by: Bayer <bayernator@protonmail.com>
Signed-off-by: Bayer <bayernator@protonmail.com>
Signed-off-by: Bayer <bayernator@protonmail.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 19, 2023

@Bayernatoor is attempting to deploy a commit to the OpenSats Team on Vercel.

A member of the Team first needs to authorize it.

@Bayernatoor Bayernatoor requested a review from dergigi December 19, 2023 11:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
os-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 6:48pm

@dergigi
Copy link
Copy Markdown
Member

dergigi commented Dec 20, 2023

run prettier

@Bayernatoor FYI you can add prettier as a plugin to your IDE so you don't have to run it manually.

@Bayernatoor
Copy link
Copy Markdown
Contributor Author

run prettier

@Bayernatoor FYI you can add prettier as a plugin to your IDE so you don't have to run it manually.

Lol I know. I use neovim and haven't taken the time to set it up. 🤦‍♂️

@dergigi
Copy link
Copy Markdown
Member

dergigi commented Dec 20, 2023

No worries, thought I'd mention it because not everyone knows these things 😅

Comment thread components/ProjectCard.tsx Outdated
Bayernatoor and others added 3 commits January 6, 2024 16:13
…ll to look good

Signed-off-by: Bayer <bayernator@protonmail.com>
Signed-off-by: Bayer <bayernator@protonmail.com>
Copy link
Copy Markdown
Member

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that's better. I'll merge this now.

@dergigi dergigi merged commit decbced into OpenSats:master Jan 15, 2024
BoltTouring pushed a commit that referenced this pull request Mar 28, 2025
* adjust image props + remove deprecated props + use customStyle prop for opensat project cards

Signed-off-by: Bayer <bayernator@protonmail.com>

* add padding bottom to Explore Projects subtext section

Signed-off-by: Bayer <bayernator@protonmail.com>

* run prettier

Signed-off-by: Bayer <bayernator@protonmail.com>

* Set object-fit based on orientation of image - horizontal requires fill to look good

Signed-off-by: Bayer <bayernator@protonmail.com>

* prettify it all

Signed-off-by: Bayer <bayernator@protonmail.com>

---------

Signed-off-by: Bayer <bayernator@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants