Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes spacing and padding values across the main application interface to improve visual consistency. The changes primarily reduce spacing values from 20 to 10 pixels and adjust padding in various components.
- Standardizes spacing values to 10 pixels across most components (down from 15-20 pixels)
- Adjusts padding values to achieve more consistent layout spacing
- Removes redundant padding from some nested containers
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/gui/app.rs |
Reduces main content column spacing from 20 to 10 pixels |
src/gui/components/control.rs |
Reduces control bar row spacing from 20 to 10 pixels |
src/gui/components/preset_bar.rs |
Reduces spacing from 20 to 10 and removes padding from container |
src/gui/components/stage_list.rs |
Replaces spacing with padding on the stage list column |
src/gui/components/ir_cabinet_control.rs |
Removes padding from the IR cabinet control content column |
src/gui/components/dialogs/settings.rs |
Reduces spacing and padding values in the settings dialog layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| pub fn view(&self) -> Element<'_, Message> { | ||
| let mut col = column![].spacing(10).width(Length::Fill); | ||
| let mut col = column![].width(Length::Fill).padding(10); |
There was a problem hiding this comment.
This change removes spacing between items in the column while adding padding around the column. This means stages in the list will no longer have any gaps between them. Consider keeping both .spacing(10) for gaps between stages AND .padding(10) for padding around the column, or use .spacing(10).padding(10) to maintain both properties.
| let mut col = column![].width(Length::Fill).padding(10); | |
| let mut col = column![].width(Length::Fill).spacing(10).padding(10); |
| .spacing(10) | ||
| .align_y(Alignment::Center) | ||
| .width(Length::Fill), | ||
| ) |
There was a problem hiding this comment.
Inconsistent padding between return paths. The container in the confirmation flow (line 112) has .padding(10), but padding was removed from this container. This creates a visual inconsistency where the preset bar will have different padding depending on which UI state is active. Either remove padding from line 112 as well, or restore padding here for consistency.
| ) | |
| ) | |
| .padding(10) |
No description provided.