fix: increase fft size in pitch shifter to improve sound quality#194
Merged
fix: increase fft size in pitch shifter to improve sound quality#194
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the FFT size used by the phase-vocoder pitch shifter to improve frequency resolution, with expected tradeoffs in CPU usage and algorithmic latency.
Changes:
- Increased
FFT_SIZEinsrc/audio/pitch_shifter.rsfrom 1024 to 2048. - Updated
Cargo.lockwith a broad set of dependency version changes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/audio/pitch_shifter.rs |
Doubles FFT size, affecting hop size, bin counts, internal buffer sizes, and latency characteristics. |
Cargo.lock |
Contains widespread dependency upgrades beyond the FFT-size change described in the PR metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a single, focused change to the
src/audio/pitch_shifter.rsfile. The size of the FFT (Fast Fourier Transform) used in the pitch shifter has been increased from 1024 to 2048, which will improve frequency resolution at the cost of increased computational load and latency.FFT_SIZEconstant from 1024 to 2048 to enhance frequency resolution in the pitch shifting algorithm.