Skip to content

fix: increase fft size in pitch shifter to improve sound quality#194

Merged
OpenSauce merged 3 commits intomainfrom
fix-fft-latency
Feb 28, 2026
Merged

fix: increase fft size in pitch shifter to improve sound quality#194
OpenSauce merged 3 commits intomainfrom
fix-fft-latency

Conversation

@OpenSauce
Copy link
Copy Markdown
Owner

This pull request makes a single, focused change to the src/audio/pitch_shifter.rs file. The size of the FFT (Fast Fourier Transform) used in the pitch shifter has been increased from 1024 to 2048, which will improve frequency resolution at the cost of increased computational load and latency.

  • Increased FFT_SIZE constant from 1024 to 2048 to enhance frequency resolution in the pitch shifting algorithm.

Copilot AI review requested due to automatic review settings February 28, 2026 16:45
@OpenSauce OpenSauce changed the title fix: increase fft size fix: increase fft size in pitch shifter Feb 28, 2026
@OpenSauce OpenSauce changed the title fix: increase fft size in pitch shifter fix: increase fft size in pitch shifter to improve sound quality Feb 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the FFT size used by the phase-vocoder pitch shifter to improve frequency resolution, with expected tradeoffs in CPU usage and algorithmic latency.

Changes:

  • Increased FFT_SIZE in src/audio/pitch_shifter.rs from 1024 to 2048.
  • Updated Cargo.lock with a broad set of dependency version changes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/audio/pitch_shifter.rs Doubles FFT size, affecting hop size, bin counts, internal buffer sizes, and latency characteristics.
Cargo.lock Contains widespread dependency upgrades beyond the FFT-size change described in the PR metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/audio/pitch_shifter.rs
@OpenSauce OpenSauce enabled auto-merge (squash) February 28, 2026 16:52
@OpenSauce OpenSauce merged commit 9cb4bc9 into main Feb 28, 2026
7 checks passed
@OpenSauce OpenSauce deleted the fix-fft-latency branch February 28, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants