Skip to content

feat: display number of x-runs and show CPU usage#195

Merged
OpenSauce merged 1 commit intomainfrom
show-xruns-and-cpu-usage
Feb 28, 2026
Merged

feat: display number of x-runs and show CPU usage#195
OpenSauce merged 1 commit intomainfrom
show-xruns-and-cpu-usage

Conversation

@OpenSauce
Copy link
Copy Markdown
Owner

Useful!

closes #193

Copilot AI review requested due to automatic review settings February 28, 2026 17:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds real-time JACK status indicators to the UI by tracking xruns (buffer underruns) and displaying current JACK CPU load in the peak meter/status area, addressing issue #193.

Changes:

  • Extend i18n Translations with new labels for xruns and CPU usage (EN + ZH_CN).
  • Track xruns via a shared Arc<AtomicU64> updated from jack::NotificationHandler::xrun.
  • Plumb xrun count + JACK CPU load into PeakMeterDisplay and render them with basic threshold-based coloring.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/i18n/mod.rs Adds translatable strings for xruns and cpu.
src/gui/components/peak_meter.rs Extends the peak meter widget to store/render xrun count and CPU load with colored status text.
src/gui/app.rs Updates the peak meter polling handler to pass xrun count and CPU load into the display.
src/audio/manager.rs Stores shared xrun counter, exposes xrun_count()/cpu_load() getters, and wires a stateful notification handler into activate_async.
src/audio/jack.rs Implements xrun() notification callback to increment the shared xrun counter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OpenSauce OpenSauce merged commit 4193978 into main Feb 28, 2026
11 checks passed
@OpenSauce OpenSauce deleted the show-xruns-and-cpu-usage branch February 28, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal when x-running

2 participants