Conversation
Implement Freeverb (Schroeder-Moorer) reverb with 8 parallel lowpass-feedback comb filters and 4 series allpass filters. Parameters: room size, damping, dry/wet mix. Delay lengths scale proportionally with sample rate. Tuning constants match Jezar's original reference implementation.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Freeverb-style reverb processing stage to the amp pipeline and exposes it in the GUI with localized (EN + ZH_CN) controls, addressing Issue #24’s request for a simple reverb stage.
Changes:
- Implement
ReverbStage(8 parallel combs + 4 serial allpasses) with Room Size, Damping, and Dry/Wet (mix) parameters. - Wire the new stage into the GUI stage registry and add a dedicated reverb stage UI panel.
- Extend i18n strings to include the new stage name and parameter labels (EN + ZH_CN).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/amp/stages/reverb.rs |
Adds the Freeverb-style reverb DSP stage implementation and unit tests. |
src/amp/stages/mod.rs |
Exposes the new reverb stage module. |
src/gui/stages/reverb.rs |
Adds GUI config/message/view for the Reverb stage sliders. |
src/gui/stages/mod.rs |
Registers the Reverb stage in the GUI stage registry macro. |
src/i18n/mod.rs |
Adds new translation keys for the Reverb stage and its parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apply DENORMAL_THRESHOLD check when writing into delay line buffers, matching the pattern used by DelayStage. Prevents denormal values from persisting in the ring buffers and causing CPU spikes on non-FTZ systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #24
Test plan
make lintpassesmake testpasses (11 new reverb tests)cargo run --release— add Reverb stage via GUI, tweak sliders, verify audible reverb tail