-
Notifications
You must be signed in to change notification settings - Fork 5
Hide Google Play downloads on iOS Tauri builds #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apple App Store policies prohibit showing alternative app stores. This change conditionally hides Google Play content on iOS devices: - Homepage: Hide Google Play badge when running on iOS - Downloads page: Hide entire Android section when running on iOS Uses existing isIOS() platform detection utility. Fixes #314 Co-authored-by: Anthony <AnthonyRonning@users.noreply.github.com>
WalkthroughThe pull request adds iOS platform checks to conditionally hide Google Play badge and Android download card on iOS, addressing Apple's build approval concerns by preventing Google-specific download UI from appearing in iOS tauri builds. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (4)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
Greptile OverviewGreptile SummaryConditionally hides Google Play/Android content from iOS Tauri builds to comply with Apple App Store policies prohibiting references to alternative app stores. Changes:
Implementation:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant App as main.tsx
participant Platform as platform.ts
participant Marketing as Marketing.tsx
participant Downloads as downloads.tsx
User->>App: Launch app
App->>Platform: waitForPlatform()
Platform->>Platform: Detect Tauri environment
Platform->>Platform: Get OS type (iOS/Android/etc)
Platform-->>App: Platform initialized
App->>App: Render React app
alt iOS Platform
App->>Marketing: Render Marketing component
Marketing->>Platform: isIOS()
Platform-->>Marketing: true
Marketing->>Marketing: Hide Google Play badge
Marketing-->>User: Show homepage (no Google Play)
User->>Downloads: Navigate to /downloads
Downloads->>Platform: isIOS()
Platform-->>Downloads: true
Downloads->>Downloads: Hide Android section
Downloads-->>User: Show only iOS & Web options
else Non-iOS Platform
App->>Marketing: Render Marketing component
Marketing->>Platform: isIOS()
Platform-->>Marketing: false
Marketing->>Marketing: Show Google Play badge
Marketing-->>User: Show homepage (with Google Play)
User->>Downloads: Navigate to /downloads
Downloads->>Platform: isIOS()
Platform-->>Downloads: false
Downloads->>Downloads: Show Android section
Downloads-->>User: Show iOS, Android & Web options
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
@TestFlight build |
|
🚀 TestFlight deployment triggered! Check the Actions tab for progress. |
|
✅ TestFlight deployment completed successfully! |
Fixes #314
Apple App Store policies prohibit showing alternative app stores. This change conditionally hides Google Play content when running on iOS devices:
Uses existing
isIOS()platform detection utility.Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.