chore: bump maple-proxy to 0.1.5 #361
Conversation
- Updated maple-proxy dependency from 0.1.4 to 0.1.5 - Fixed unused import (Manager) in src/lib.rs - Removed redundant import (tauri_plugin_opener) in src/lib.rs - Fixed unnecessary to_string() call in deep link handler Co-authored-by: Anthony <AnthonyRonning@users.noreply.github.com>
📝 WalkthroughWalkthroughBumps the Changes
Sequence Diagram(s)(omitted — changes are small refactor and dependency bump, not a multi-component control-flow change) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
Comment |
Greptile SummaryUpdated
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Cargo as Cargo.toml
participant Lock as Cargo.lock
participant Registry as crates.io
participant Proxy as maple-proxy 0.1.5
participant OpenSecret as opensecret 0.2.7
participant App as Tauri App
Dev->>Cargo: Update maple-proxy to 0.1.5
Cargo->>Registry: Resolve dependencies
Registry->>Cargo: Provide maple-proxy 0.1.5
Registry->>Cargo: Provide opensecret 0.2.7 (transitive)
Cargo->>Lock: Update lock file with checksums
Lock-->>Proxy: Lock maple-proxy@0.1.5
Lock-->>OpenSecret: Lock opensecret@0.2.7
Dev->>App: Fix clippy warnings (unused imports, .as_ref())
App->>Proxy: Enable embedding proxy API support
Note over App,Proxy: Embedding API now available via maple-proxy
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (1)
-
frontend/src-tauri/src/lib.rs, line 265 (link)style: Inconsistent URL handling: desktop version uses
url.as_ref()(line 69) but mobile still uses&url.to_string(). Consider applying the same clippy fix here for consistency.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 files reviewed, 1 comment
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src-tauri/src/lib.rs (1)
69-69: LGTM! However, inconsistent with mobile code path.The refactor from
&url.to_string()tourl.as_ref()is excellent - it's more idiomatic and avoids unnecessary allocation of a temporary String.However, line 265 in the mobile code path still uses the old pattern:
&url.to_string(). Consider applying the same refactor for consistency.🔎 Proposed fix for consistency
app.deep_link().on_open_url(move |event| { if let Some(url) = event.urls().first() { - handle_deep_link_event(&url.to_string(), &app_handle); + handle_deep_link_event(url.as_ref(), &app_handle); } });
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
frontend/src-tauri/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
frontend/src-tauri/Cargo.tomlfrontend/src-tauri/src/lib.rs
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-02T22:53:39.374Z
Learnt from: AnthonyRonning
Repo: OpenSecretCloud/Maple PR: 136
File: frontend/src-tauri/tauri.conf.json:4-4
Timestamp: 2025-07-02T22:53:39.374Z
Learning: When reviewing version bump PRs, version numbers found in Cargo.lock files are typically dependency versions (like aho-corasick), not the application version. Don't suggest updating these unless they are specifically the application's own version entry.
Applied to files:
frontend/src-tauri/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: build-macos (universal-apple-darwin)
- GitHub Check: build-linux
- GitHub Check: build-android
- GitHub Check: build-ios
- GitHub Check: Greptile Review
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
frontend/src-tauri/src/lib.rs (1)
1-1: Verify that theManagertrait is not used elsewhere in the codebase before removing it from the import.The removal of
Managerfrom the import statement should be safe if it's no longer referenced, but this needs to be confirmed by searching the file and related code for any usages ofManagertrait methods or re-exports.frontend/src-tauri/Cargo.toml (1)
35-35: Verify maple-proxy version availability on crates.io.The specified version 0.1.5 does not exist in the published crate index—only versions 0.1.1 and 0.1.3 are available. Similarly, version 0.2.7 mentioned in issue #360 is not published. This will cause the build to fail. Confirm which version is actually needed and update the dependency accordingly.
⛔ Skipped due to learnings
Learnt from: AnthonyRonning Repo: OpenSecretCloud/Maple PR: 136 File: frontend/src-tauri/tauri.conf.json:4-4 Timestamp: 2025-07-02T22:53:39.374Z Learning: When reviewing version bump PRs, version numbers found in Cargo.lock files are typically dependency versions (like aho-corasick), not the application version. Don't suggest updating these unless they are specifically the application's own version entry.
|
@claude my AI's are complaining about this: should you handle this? or not a problem? Also i'm concerned about the removal of the "unused" import. are you sure it was unused on ALL environments we build for? not just the env you're running on? if it truly is unused then good. if something used it then either do an environment flag or add it back and ignore the unused error. |
|
Claude finished @AnthonyRonning's task in 5m 22s —— View job Investigation Complete ✅Tasks
Findings1. Removed imports are safe ✅
Both removals are safe across all build targets (desktop, iOS, Android). These were correctly identified as unused by clippy. 2. URL handling inconsistency fixed ✅
Changes MadeApplied the same clippy fix to the mobile code path (line 265) for consistency:
Verification: All checks passed ✅
Commit: SummaryYour concerns were valid! The AI reviewers were correct:
The PR is now fully consistent and all clippy warnings are resolved. |
Co-authored-by: Anthony <AnthonyRonning@users.noreply.github.com>
Deploying maple with
|
| Latest commit: |
2fa0b42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3806574b.maple-ca8.pages.dev |
| Branch Preview URL: | https://claude-issue-360-20260102-17.maple-ca8.pages.dev |
This PR updates the maple-proxy dependency to version 0.1.5, which adds embedding proxy API support.
Changes
Closes #360
Generated with Claude Code
Summary by CodeRabbit
Chores
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.