Skip to content

Conversation

@AnthonyRonning
Copy link
Contributor

@AnthonyRonning AnthonyRonning commented Jan 20, 2026

Split the deep-link mobile config into separate entries so the plugin generates individual intent-filters for each path. This ensures proper Android App Links verification for /payment-success, /payment-canceled, and /pricing paths.

Changes:

  • Split combined pathPrefix array into separate mobile config entries
  • Removed redundant cloud.opensecret.maple scheme from deep-link config (already manually maintained in AndroidManifest.xml outside the auto-generated section)

This fixes the issue where running just android-build would regenerate a different AndroidManifest than what was committed.

Summary by CodeRabbit

  • Mobile & Deep Linking
    • Improved mobile app deep linking for payment flows, ensuring proper routing when users complete or cancel payments
    • Enhanced pricing page deep link configuration for seamless mobile navigation

✏️ Tip: You can customize this high-level summary in your review settings.

Split the deep-link mobile config into separate entries so the plugin
generates individual intent-filters for each path. This ensures proper
Android App Links verification for /payment-success, /payment-canceled,
and /pricing paths.

Removed redundant cloud.opensecret.maple scheme from deep-link config
since it's already manually maintained in AndroidManifest.xml.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the mobile deep-link configuration in the Tauri application, replacing a cloud-based scheme with explicit HTTPS-based routes for payment processing. Three deep-link entries are configured: payment-success, payment-canceled, and pricing, all using https://trymaple.ai as the host with specific path prefixes.

Changes

Cohort / File(s) Summary
Mobile Deep-Link Configuration
frontend/src-tauri/tauri.conf.json
Replaced single cloud.opensecret.maple deep-link entry with three explicit HTTPS-based entries targeting trymaple.ai: payment-success (/payment-success), payment-canceled (/payment-canceled), and pricing (/pricing). appLink enabled for all entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through payment flows,
Where deep links point to trymaple.ai,
Success and cancel paths now show,
HTTPS routes reaching the sky,
Config changes make dreams grow! 🌟

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: separating deep links into individual intent-filters for Android, which directly matches the primary objective of the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying maple with  Cloudflare Pages  Cloudflare Pages

Latest commit: 63cba86
Status: ✅  Deploy successful!
Preview URL: https://9ee18961.maple-ca8.pages.dev
Branch Preview URL: https://fix-android-manifest-deep-li.maple-ca8.pages.dev

View logs

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Overview

Greptile Summary

Fixed configuration drift between tauri.conf.json and the auto-generated AndroidManifest.xml by splitting the deep-link mobile config into separate entries for each path.

  • Restructured deep-link configuration from single entry with array of paths to three separate entries
  • Each entry now generates its own intent-filter for proper Android App Links verification
  • Removed redundant cloud.opensecret.maple scheme entry (already maintained manually in AndroidManifest)
  • Ensures just android-build generates consistent output matching the committed manifest

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Configuration change properly addresses build inconsistency by aligning source config with desired output, no logic changes or runtime impact
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src-tauri/tauri.conf.json Split combined pathPrefix array into three separate mobile config entries for individual intent-filter generation, removed redundant custom scheme entry

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Config as tauri.conf.json
    participant Build as Tauri Build
    participant Manifest as AndroidManifest.xml
    participant Android as Android System

    Note over Dev,Config: Before Fix
    Dev->>Config: Multiple paths in single array<br/>["/payment-success", "/payment-canceled", "/pricing"]
    Dev->>Build: Run `just android-build`
    Build->>Config: Read mobile deep-link config
    Build->>Manifest: Generate single intent-filter<br/>with multiple pathPrefix tags
    Note over Manifest: ❌ Different from committed version
    
    Note over Dev,Config: After Fix
    Dev->>Config: Split into 3 separate entries<br/>One per path
    Dev->>Build: Run `just android-build`
    Build->>Config: Read mobile deep-link config
    Build->>Manifest: Generate 3 separate intent-filters<br/>One per path
    Manifest->>Android: Each intent-filter verified independently
    Android->>Android: Proper App Links verification<br/>for /payment-success, /payment-canceled, /pricing
    Note over Manifest: ✅ Matches committed version
Loading

@AnthonyRonning AnthonyRonning merged commit 9e8ab65 into master Jan 20, 2026
12 checks passed
@AnthonyRonning AnthonyRonning deleted the fix/android-manifest-deep-links branch January 20, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants