Skip to content

Conversation

@hhvrc
Copy link
Contributor

@hhvrc hhvrc commented Aug 14, 2025

No description provided.

@hhvrc hhvrc self-assigned this Aug 14, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Aug 14, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2025

⚠️ No Changeset found

Latest commit: 70f25f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LucHeart LucHeart requested a review from Copilot August 14, 2025 22:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the RMT (Remote Control Transceiver) and RF transmitter architecture to improve code organization and logic handling. The changes move from a MainEncoder class to a Sequence class and consolidate command processing logic.

  • Replaced MainEncoder class with a more comprehensive Sequence class that includes transmission timing
  • Moved Stop command handling from CommandHandler to RFTransmitter for better encapsulation
  • Improved variable naming and code organization with better constants and structure definitions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/radio/rmt/Sequence.cpp New implementation of Sequence class replacing MainEncoder functionality
src/radio/rmt/MainEncoder.cpp Removed old MainEncoder implementation
src/radio/RFTransmitter.cpp Refactored to use Sequence class, improved naming, and moved Stop command logic
src/CommandHandler.cpp Removed Stop command handling logic that moved to RFTransmitter
include/radio/rmt/Sequence.h Updated header from MainEncoder to Sequence with additional timing functionality
include/radio/RFTransmitter.h Added forward declaration for Command struct

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

hhvrc and others added 4 commits August 15, 2025 00:08
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v18.1.3) reports: 1 file(s) not formatted
  • src/CommandHandler.cpp

Have any feedback or feature suggestions? Share it here.

@hhvrc hhvrc merged commit 6f3f4fb into develop Aug 14, 2025
40 checks passed
@hhvrc hhvrc deleted the feature/better-rf-transmitter-logic branch August 14, 2025 23:49
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Aug 14, 2025
@hhvrc hhvrc added this to the 1.5.0 Release milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants