-
Notifications
You must be signed in to change notification settings - Fork 17
Better RMT and RFTX logic #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors the RMT (Remote Control Transceiver) and RF transmitter architecture to improve code organization and logic handling. The changes move from a MainEncoder class to a Sequence class and consolidate command processing logic.
- Replaced
MainEncoderclass with a more comprehensiveSequenceclass that includes transmission timing - Moved Stop command handling from
CommandHandlertoRFTransmitterfor better encapsulation - Improved variable naming and code organization with better constants and structure definitions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/radio/rmt/Sequence.cpp | New implementation of Sequence class replacing MainEncoder functionality |
| src/radio/rmt/MainEncoder.cpp | Removed old MainEncoder implementation |
| src/radio/RFTransmitter.cpp | Refactored to use Sequence class, improved naming, and moved Stop command logic |
| src/CommandHandler.cpp | Removed Stop command handling logic that moved to RFTransmitter |
| include/radio/rmt/Sequence.h | Updated header from MainEncoder to Sequence with additional timing functionality |
| include/radio/RFTransmitter.h | Added forward declaration for Command struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Cpp-Linter Report
|
No description provided.