Skip to content

Improve EStop Manager's atomics + set to Idle when changing pin/enabled. #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhvrc merged 11 commits into from
May 26, 2026
Merged

Improve EStop Manager's atomics + set to Idle when changing pin/enabled. #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e03975
Improve EStop Manager's atomics + set to Idle when changing pin/enabled.
nullstalgia Apr 20, 2026
58bf773
Address comments
nullstalgia Apr 20, 2026
8041e11
Use more appropriate ordering for loading/storing estopPins
nullstalgia Apr 20, 2026
2274b9d
Oops, didn't change calls after renaming functions
nullstalgia Apr 20, 2026
c92ea6c
Address UB in atomic store operations
nullstalgia Apr 21, 2026
3e5eab3
Defining behavior once more
nullstalgia Apr 21, 2026
8a3e874
Some restructuring and change in atomic ordering
hhvrc Apr 22, 2026
0491549
clang-format
hhvrc Apr 22, 2026
af2f4f4
Merge branch 'develop' into feat/improve-estop-atomics
hhvrc Apr 22, 2026
f039473
Update EStopManager.cpp
hhvrc May 26, 2026
78866de
Fix formatting n linting
hhvrc May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ AlignTrailingComments:
OverEmptyLines: 1
AllowAllArgumentsOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Always
AllowShortBlocksOnASingleLine: Never
AllowShortCaseLabelsOnASingleLine: false
AllowShortEnumsOnASingleLine: false
AllowShortFunctionsOnASingleLine: InlineOnly
Expand Down
2 changes: 1 addition & 1 deletion include/estop/EStopManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#pragma once

Check warning on line 1 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:1:1 [portability-avoid-pragma-once] 

avoid 'pragma once' directive; use include guards instead

#include "estop/EStopState.h"

Expand All @@ -7,11 +7,11 @@
#include <cstdint>

namespace OpenShock::EStopManager {
[[nodiscard]] bool Init();

Check warning on line 10 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:10:22 [modernize-use-trailing-return-type] 

use a trailing return type for this function
bool SetEStopEnabled(bool enabled);

Check warning on line 11 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:11:8 [modernize-use-trailing-return-type] 

use a trailing return type for this function
bool SetEStopPin(gpio_num_t pin);

Check warning on line 12 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:12:8 [modernize-use-trailing-return-type] 

use a trailing return type for this function
bool IsEStopped();

Check warning on line 13 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:13:8 [modernize-use-trailing-return-type] 

use a trailing return type for this function
int64_t LastEStopped();

Check warning on line 14 in include/estop/EStopManager.h

View workflow job for this annotation

GitHub Actions / C/C++ Linter

include/estop/EStopManager.h:14:11 [modernize-use-trailing-return-type] 

use a trailing return type for this function

void Trigger();
void SoftwareTrigger();
} // namespace OpenShock::EStopManager
Loading