Merged
Conversation
Contributor
Author
|
Merging this, as it has no effect currently unless it's manually invoked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like OpenShot/libopenshot-audio#95, this adds a
version.shscript at the root of the repo which extracts thePROJECT_VERSION_FULLstring fromCMakeLists.txt, and for the same reasons:So, same thing with libopenshot:
One advantage being, you don't have to give the libopenshot
cmakerun the location of alibopenshot-audioinstalled this way, since anything in the homebrew space is considered "system-installed". (With the right user environment variables set, at least.brew shellenvcan be used to automatically apply that setup.)