Implemented position remapper inside FrameMapper to fix audio noise when exporting to different fps#578
Merged
jonoomph merged 1 commit intoclip-refactor-keyframesfrom Oct 13, 2020
Merged
Conversation
…hen exporting to different fps The FrameMapper class now receives the updated clip position and returns the correct amount of samples for a given frame number
Codecov Report
@@ Coverage Diff @@
## clip-refactor-keyframes #578 +/- ##
===========================================================
+ Coverage 49.39% 51.69% +2.29%
===========================================================
Files 129 130 +1
Lines 10198 11501 +1303
===========================================================
+ Hits 5037 5945 +908
- Misses 5161 5556 +395
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented position remapper inside FrameMapper to fix audio noise when exporting to different fps
The FrameMapper class now receives the updated clip position and returns the correct amount of samples for a given frame number.