Skip to content

Implemented position remapper inside FrameMapper to fix audio noise when exporting to different fps#578

Merged
jonoomph merged 1 commit intoclip-refactor-keyframesfrom
audio_fix
Oct 13, 2020
Merged

Implemented position remapper inside FrameMapper to fix audio noise when exporting to different fps#578
jonoomph merged 1 commit intoclip-refactor-keyframesfrom
audio_fix

Conversation

@jonoomph
Copy link
Copy Markdown
Member

Implemented position remapper inside FrameMapper to fix audio noise when exporting to different fps

The FrameMapper class now receives the updated clip position and returns the correct amount of samples for a given frame number.

…hen exporting to different fps

The FrameMapper class now receives the updated clip position and returns the correct amount of samples for a given frame number
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2020

Codecov Report

Merging #578 into clip-refactor-keyframes will increase coverage by 2.29%.
The diff coverage is 96.38%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           clip-refactor-keyframes     #578      +/-   ##
===========================================================
+ Coverage                    49.39%   51.69%   +2.29%     
===========================================================
  Files                          129      130       +1     
  Lines                        10198    11501    +1303     
===========================================================
+ Hits                          5037     5945     +908     
- Misses                        5161     5556     +395     
Impacted Files Coverage Δ
include/FrameMapper.h 75.00% <ø> (ø)
src/Timeline.cpp 47.48% <75.00%> (+6.39%) ⬆️
src/FrameMapper.cpp 84.32% <90.47%> (+0.99%) ⬆️
tests/FrameMapper_Tests.cpp 98.55% <100.00%> (+0.77%) ⬆️
include/effects/Blur.h 50.00% <0.00%> (-50.00%) ⬇️
include/effects/Negate.h 50.00% <0.00%> (-50.00%) ⬇️
include/Clip.h 70.58% <0.00%> (-18.31%) ⬇️
src/QtImageReader.cpp 56.20% <0.00%> (-5.12%) ⬇️
include/Timeline.h 59.45% <0.00%> (-4.18%) ⬇️
src/EffectBase.cpp 17.50% <0.00%> (-1.02%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 414a2cd...58cedb6. Read the comment docs.

@jonoomph jonoomph merged commit 1b670a7 into clip-refactor-keyframes Oct 13, 2020
@jonoomph jonoomph deleted the audio_fix branch October 13, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants