New "Caption" Effect (Supports VTT and Subrip formats)#583
Merged
Conversation
…(limited support, no formating, no regions)
# Conflicts: # src/effects/Caption.h
- Added background color and alpha - Added font color alpha - Added fade in / out logic - Added background padding & rounded corners - Added adjustable font name
…ers see a valid example) - Append some newlines onto the end of any caption text... needed by the regex for some reason - Updated font name and caption text to be a new type (font and caption), and we have corresponding UI changes for those on openshot-qt
Codecov Report
@@ Coverage Diff @@
## develop #583 +/- ##
===========================================
- Coverage 50.10% 49.88% -0.23%
===========================================
Files 130 132 +2
Lines 10324 11273 +949
===========================================
+ Hits 5173 5623 +450
- Misses 5151 5650 +499
Continue to review full report at Codecov.
|
Member
Author
|
Merging this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new effect, which allows for VTT or Subrip caption data to be displayed over a clip. Many different keyframes are available, from font-size, color, background color, alpha, corner radius, padding, font family, stroke, etc... Also, word-wrap is supported, and custom margins for left, top, and right (didn't include bottom because I didn't want to crop the text off). You can also set/animate a custom fade-in / fade-out for each caption, which gives it a nice animated look.
This not yet implemented:
<b><i><u><font color=""></font></u></i></b>Pretty much we parse the basic timestamp and caption text out, and display when it's the correct time... augmented by all the animation keyframes that are set.