Reduce dependencies by eliminating unnecessary components#668
Merged
ferdnyc merged 3 commits intoOpenShot:developfrom Apr 29, 2021
Merged
Reduce dependencies by eliminating unnecessary components#668ferdnyc merged 3 commits intoOpenShot:developfrom
ferdnyc merged 3 commits intoOpenShot:developfrom
Conversation
- We don't make use of any part of avdevice, avfilter, or postproc, so remove all of those from the package COMPONENTS list. - In addition, the deprecated avresample will only be linked/used if swresample is not present on the system.
ferdnyc
added
the
build
Codecov Report
@@ Coverage Diff @@
## develop #668 +/- ##
========================================
Coverage 52.42% 52.42%
========================================
Files 151 151
Lines 12346 12346
========================================
Hits 6473 6473
Misses 5873 5873 Continue to review full report at Codecov.
|
Avoids having to recompile it for every target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't actually use ImageMagick's MagickWand API at all, ditto for ffmpeg's avdevice, avfilter, or postproc. We also don't use avresample, except when swresample is unavailable. So, this PR pares down the modules we do link with and depend on to just the set we actually use.
Also, when using the bundled jsoncpp, building it as an
OBJECTtarget saves us from having to recompile it for each target it's linked to. (Which will save a lot of time, especially now that each unit test class is a separate target. Number of times jsoncpp is compiled during the build goes down from 26 to just 1.)