feat: Add automatic elevation propagation#89
Merged
dietmarw merged 12 commits intoOpenSimHub:masterfrom Apr 13, 2026
Merged
Conversation
The elevation gets automatically propagated via the connects
Relocates elevation equations (`o.z = i.z` or `o.z = i.z - H`) from the `equation` section to the `initial equation` section for most components. This ensures elevation values are determined once at initialization and then propagated through the connected topology, simplifying model structure and potentially improving simulation performance. Introduces a `fixElevation` parameter for source and sink models (e.g., `Reservoir`, `VolumeFlowSource`). This parameter allows users to either: - Enforce a fixed absolute elevation (`z_0`) at the outlet (when `fixElevation` is true, default). - Allow the outlet elevation to be determined by the connected topology (when `fixElevation` is false), enabling more flexible model configurations where elevation propagates into these components.
The previous variant did not allow for parallel connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces elevation handling and propagation mechanism across the OpenHPL library.
ref: #45
Key changes include:
Elevationrecord which uses an overconstrainedequalityConstraintfor more reliable elevation propagation throughout the system.showElevationparameter to theDatarecord, enabling global control over the display of elevation on connectors in the icon layer.