Skip to content

Basic UI#23

Merged
paoloambrosio merged 13 commits into
OpenSimTools:mainfrom
paoloambrosio:9-winui3-standalone
May 27, 2023
Merged

Basic UI#23
paoloambrosio merged 13 commits into
OpenSimTools:mainfrom
paoloambrosio:9-winui3-standalone

Conversation

@paoloambrosio
Copy link
Copy Markdown
Contributor

@paoloambrosio paoloambrosio commented May 1, 2023

Relates to #9.

  • Display current state of mods
  • Enable/disable mods
    • Move logic outside of view model
  • Sync mods with game
  • Install mods by drag and drop to list view
    • Duplicate entry if a mod has been deleted but is still installed (so shown in the list)
    • What if a mod with the same name exists already?
  • Package
    • Needs changing to build CLI as well
  • Delete mods with multi-selection and delete key or context menu
  • Application icon, window title, etc.
    • Unbelievable that window size and icon are not implemented in WinUI (we have to use WinUIEx)
  • Sort list by package name
  • Fix crash if Mods is not present

Postponed to separate PR:

  • Error handling
    • Problem: the application would currently die on any ModManager error (e.g. InstallEnabledMods, FetchState, ...)
    • Need to find a nice way to show errors
  • Modal dialog for installation: it requires events during installation
    • Progress bar in the main window (side of sync?)
    • Should we add the size of the archive for the progress bar?
    • Modal dialog only for logs, with a close button
      • Need to pass either a logger interface or an output writer
      • The logger interface could be injected with dependency injection and a custom log provider that (also?) updates the UI?
  • Enable sync only when to install is different from installed: it requires information on mod updates
    • Problem: what if a mod is upgraded to a new version with the same name? Button always enabled as force sync?
  • Prevent menu flyout from opening if nothing is selected
  • Drag and drop into list should move if on the same drive and copy otherwise?
    • It would be nice to allow the shift modifier to change from copy to move if on the same drive

@paoloambrosio paoloambrosio force-pushed the 9-winui3-standalone branch 6 times, most recently from eadd296 to 78b72a9 Compare May 3, 2023 05:47
@paoloambrosio paoloambrosio force-pushed the 9-winui3-standalone branch 3 times, most recently from a2a4bb5 to 918c472 Compare May 27, 2023 06:59
@paoloambrosio paoloambrosio force-pushed the 9-winui3-standalone branch from bde9daf to cfaa9f7 Compare May 27, 2023 09:35
@paoloambrosio paoloambrosio marked this pull request as ready for review May 27, 2023 16:59
@paoloambrosio paoloambrosio merged commit 7320951 into OpenSimTools:main May 27, 2023
@paoloambrosio paoloambrosio deleted the 9-winui3-standalone branch May 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant