-
Notifications
You must be signed in to change notification settings - Fork 130
Detected... message references sensors (issue #147) #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e657e6 to
7c37fc2
Compare
|
Rebased onto master for merging. |
|
@carsten-kuebler I guess I don't get the fact why it should be redundant: |
|
@CarloVanDriestenBMW It is redundant because you can determine the Sensor ID list 'SD_L' for a Detected... entity 'E' from the SensorData detection list list 'D_L_L'. With this algorithm you can generate the sensor ID list. Yes, it is very time consuming and inefficient... |
7c37fc2 to
1252443
Compare
Add a list of sensor ids to all Detected... messages. These sensors confirm this Detected... 'object'. It is a redundant info.
1252443 to
2608167
Compare
|
@carsten-kuebler @CarloVanDriestenBMW I've rebased to current master, to solve the merge conflicts. Please reset --hard after fetching if you want to continue work on this branch (besides merging, which can happen as is). |
|
@carsten-kuebler as we discussed in the workshop. We will remove the comment about the redundancy and explain the purpose of this field regarding objects when no detection is available |
This PR adress issue #147
Add a list of sensor ids to all Detected... messages. These sensors confirm this Detected... 'object'. It is a redundant info.