Skip to content

Conversation

@carsten-kuebler
Copy link
Contributor

This PR adress issue #147

Add a list of sensor ids to all Detected... messages. These sensors confirm this Detected... 'object'. It is a redundant info.

@pmai pmai force-pushed the feature/detected_xxx_sensor_list branch from 7e657e6 to 7c37fc2 Compare March 2, 2018 10:30
@pmai pmai self-assigned this Mar 2, 2018
@pmai
Copy link
Contributor

pmai commented Mar 2, 2018

Rebased onto master for merging.

@ghost ghost added this to the v3.0.0 milestone Mar 2, 2018
@ghost ghost added the FeatureRequest Proposals which enhance the interface or add additional features. label Mar 2, 2018
@ghost
Copy link

ghost commented Mar 3, 2018

@carsten-kuebler I guess I don't get the fact why it should be redundant:
You have a logic model which does the sensor fusion from two previously generated SensorData messages. The LM creates a new SensorData message which points to the same groundTruth (Both inputs might have this in common because otherwise one had to merge the GT messages). This new SD message now has detectedObjects with a new repeated ID which holds the IDS of the sensor models from which the input messages came and the overall SD ID refers to the ID of the LM?

@carsten-kuebler
Copy link
Contributor Author

@CarloVanDriestenBMW It is redundant because you can determine the Sensor ID list 'SD_L' for a Detected... entity 'E' from the SensorData detection list list 'D_L_L'.
For each Detection 'D' in 'D_L_L' with 'D'.object_id == 'E'.id: determine 'D' 's sensor mounting position 'MP' (take the 'MP' from the header of the detection list), determine sensor's ID 'S_ID' from 'MP' ('MP' is unique for one sensor), add 'S_ID' to 'SD_L' (if 'S_ID' is not present in 'SD_L').

With this algorithm you can generate the sensor ID list.

Yes, it is very time consuming and inefficient...

@pmai pmai force-pushed the feature/detected_xxx_sensor_list branch from 7c37fc2 to 1252443 Compare March 5, 2018 15:34
Add a list of sensor ids to all Detected... messages. These sensors confirm this Detected... 'object'. It is a redundant info.
@pmai pmai force-pushed the feature/detected_xxx_sensor_list branch from 1252443 to 2608167 Compare March 5, 2018 16:02
@pmai
Copy link
Contributor

pmai commented Mar 5, 2018

@carsten-kuebler @CarloVanDriestenBMW I've rebased to current master, to solve the merge conflicts. Please reset --hard after fetching if you want to continue work on this branch (besides merging, which can happen as is).

@ghost
Copy link

ghost commented Mar 15, 2018

@carsten-kuebler as we discussed in the workshop. We will remove the comment about the redundancy and explain the purpose of this field regarding objects when no detection is available

@carsten-kuebler
Copy link
Contributor Author

@pmai I made a second PR #161

@ghost ghost closed this Mar 16, 2018
@pmai pmai deleted the feature/detected_xxx_sensor_list branch April 27, 2020 11:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants