Conversation
jdsika
approved these changes
Nov 5, 2019
| - cmake -D CMAKE_PREFIX_PATH:PATH=${DEPS_DIR}/protobuf/install .. | ||
| - cmake --build . | ||
| - cd .. | ||
| name: 'Test protobuf 3.0.0 syntax' |
Contributor
There was a problem hiding this comment.
Should this be positioned above "test: "?
Contributor
Author
There was a problem hiding this comment.
let me check on my fork if it works
Contributor
There was a problem hiding this comment.
I would like to merge in the next 30min if possible :)
Contributor
Author
There was a problem hiding this comment.
For some reason it needs to be under scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Related issue. Just for more test coverage in the CI pipeline which includes also the protobuf 3 syntax through the usage of the script convert-to-proto3.sh.
Add a description
What is this change?
This PR divides the travis ci into two stages one for testing and one for depolying. Inside the stage testing there will be executed two jobs in parallel. One job is for testing the build with protobuf 2 syntax the other job is for testing the build with protobuf 3. The deploy stage has the same code as the protobuf 2 test because currently you can't share files between jobs or stages see quote below from here:
What does it fix?
Covers the testing for the protobuf 3 syntax if it is able to build.
How has it been tested?
In my fork here you can see the builds of each stage. See also the current travis build.
Mention a member
@jdsika pls review.
Check the checklist