Skip to content

Conversation

@solosito
Copy link

@solosito solosito commented Sep 9, 2017

This is the first approximation to the lane driving direction. It is not ready to be merged. First has to be analysed and discussed as described in the issue #84

@ghost ghost added the FeatureRequest Proposals which enhance the interface or add additional features. label Sep 11, 2017
@ghost
Copy link

ghost commented Sep 11, 2017

Thank you for your contribution. I would like to take some time for a review and discuss it with the tool developer.

@ghost ghost assigned HendrikAmelunxen and unassigned KarstenKruegeldSPACE Sep 11, 2017
@ghost
Copy link

ghost commented Sep 11, 2017

This is the line, that a typical vehicle is supposed to follow. Thus, if the road narrows (e.g. construction site) this line is supposed to describe the trajectory that the vehicle should follow. The intended direction of travel on the lane is given by the direction defined by the sequence of points forming the center line.

This comment in osi:lane center_lane has to be updated then?

@solosito
Copy link
Author

This comment in osi:lane center_lane has to be updated then?

Actually yes. It should specify that the intended driving direction it is not described by the center_line but by the lane_driving_direction.

@ghost ghost assigned carsten-kuebler Nov 16, 2017
@ghost
Copy link

ghost commented Dec 7, 2017

Hi @solosito ,
we considered your feedback and will introduce a lane driving direction in the OSI 2.3.0 release on Jan. 26th. We would consider using a vector3d in order to describe the direction. Would this be suitable for you?
Best regards
Carlo

@solosito
Copy link
Author

Hallo @CarloVanDriestenBMW ,
I think it is a good idea using a vector3d rather than using a flag. The driving direction could be defined more precisely.
Best regards,
Alfonso.

@AndreHildebrandt
Copy link

AndreHildebrandt commented Dec 11, 2017

Hello @CarloVanDriestenBMW, @pmai

I think, that a Vector3D alone would not be sufficient. One would need either a second vector3D or an orientation3D IMHO.
Example: A hairpin curve. The IntendedDrivingDirection is then depending on the position of the vector3D. One needs a point of reference and a driving direction.

Apart from that, there has been the suggestion to replace the successor and predecessor lane ids by LaneConnectionPair ids. Do they implicitly define the intended driving direction?

Best wishes,
Andre Hildebrandt

@solosito
Copy link
Author

Hi again,

then the initial suggestion of having a flag is a very good option. There is no need to have a tangential vector of the curve to know which is the intended driving direction as the curve itself contains that information. It is only necessary to know whether the intended driving direction follows the points' storing order or its reverse.

Thus, in case of conversions from left- to right-hand traffic and vice-versa, it would be as simple as changing this flag to the proper value.


@AndreHildebrandt

Apart from that, there has been the suggestion to replace the successor and predecessor lane ids by LaneConnectionPair ids. Do they implicitly define the intended driving direction?

No. What would be the intended driving direction in case of having just a single lane with a permanent id?

@carsten-kuebler
Copy link
Contributor

At the OSI workshop in Ulm (2017) there was a discussion to add a driving direction. But that does't suit as @AndreHildebrandt mentioned. Therefore you have to specify start point and driving direction or a flag as proposed from @solosito.
Bidirectional lanes or small lanes require 2 center lines and there is no left and right. So I proposed #110.

@ghost
Copy link

ghost commented Feb 6, 2018

@solosito is the following solution ok for you? You can find it in #110

optional bool center_line_is_driving_direction = 4;

@ghost
Copy link

ghost commented Feb 9, 2018

@pmai there are some new comments in #110 - I will close the issue and you can merge the comments.

@ghost ghost closed this Feb 9, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants