-
Notifications
You must be signed in to change notification settings - Fork 130
Add lane driving direction to the message lane (#84) #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lane driving direction to the message lane (#84) #85
Conversation
|
Thank you for your contribution. I would like to take some time for a review and discuss it with the tool developer. |
This comment in osi:lane center_lane has to be updated then? |
Actually yes. It should specify that the intended driving direction it is not described by the center_line but by the lane_driving_direction. |
|
Hi @solosito , |
|
Hallo @CarloVanDriestenBMW , |
|
Hello @CarloVanDriestenBMW, @pmai I think, that a Vector3D alone would not be sufficient. One would need either a second vector3D or an orientation3D IMHO. Apart from that, there has been the suggestion to replace the successor and predecessor lane ids by LaneConnectionPair ids. Do they implicitly define the intended driving direction? Best wishes, |
|
Hi again, then the initial suggestion of having a flag is a very good option. There is no need to have a tangential vector of the curve to know which is the intended driving direction as the curve itself contains that information. It is only necessary to know whether the intended driving direction follows the points' storing order or its reverse. Thus, in case of conversions from left- to right-hand traffic and vice-versa, it would be as simple as changing this flag to the proper value.
No. What would be the intended driving direction in case of having just a single lane with a permanent id? |
|
At the OSI workshop in Ulm (2017) there was a discussion to add a driving direction. But that does't suit as @AndreHildebrandt mentioned. Therefore you have to specify start point and driving direction or a flag as proposed from @solosito. |
This is the first approximation to the lane driving direction. It is not ready to be merged. First has to be analysed and discussed as described in the issue #84