Skip to content

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Jan 29, 2020

Reference to a related issue in the repository

This PR does some minor updates to the PR here and updates the osi submodule with rules.

Description

This PR updates the OSI submodule so it can parse the rules from the comments and fixes a typo in travis ci. I also added PyYaml to the dependecies of osi-validator since it is needed to generate yml files.

Change notes:

  • fixed typo in travis ci
  • added PyYaml to validator dependecies
  • updated osi submodule so it points to the commit with rules so that the validator can use them
  • added test for txt2osi, so only a *.txt file is uploaded and converted and validated hence removing the small_test.osi.lzma
  • added line for closing the trace file in osi_general-validator.py
  • removed line in osi_trace.py where it was opening the file twice
  • added better if statement to identify end of file (self.trace_file.tell() == trace_size)

Mention a member

@jdsika pls review and merge thanks :)

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@jdsika
Copy link
Contributor

jdsika commented Jan 29, 2020

I think I need some time tomorrow to review

@jdsika jdsika merged commit e294a86 into master Feb 6, 2020
@jdsika jdsika deleted the fix-typo branch January 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants