Skip to content

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Jan 13, 2020

Reference to a related issue in the repository

The main feature request.
The travis CI should work after merging the PR.

Add a description

This PR implements a rule parse which generates yml files with rules which then can be used to validate osi trace files.

Mention a member

@jdsika let me know your thoughts. I implemented tests with the parsed rules in the travis ci but currently it will fail because the rules.yml file is not on the master branch of the OSI repository. Theoretically it should work after the OSI PR merge.

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@jdsika jdsika added the feature request Proposals which enhance the interface or add additional features. label Jan 13, 2020
@pmai pmai merged commit ec9811a into master Jan 27, 2020
@vkresch vkresch mentioned this pull request Jan 29, 2020
6 tasks
@jdsika jdsika deleted the parse-rules branch January 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants