Skip to content

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Feb 18, 2020

Reference to a related issue in the repository

No issue just improving the quality.

Add a description

Change notes PR

  • update the osi submodule with the new regex for rules
  • adds a custom generated trace file with 50 message from the documentation for validation test
  • removed version definition from PyYaml since later versions does not have the method Fullloader
  • added black code formatter to CI and formatted the actual code with it
  • added vulture to the CI to search for dead unused code
  • removed redundant code and unnecessary folder pyosi

Mention a member

@jdsika pls review :)

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@vkresch vkresch added the quality Quality improvements. label Feb 18, 2020
@vkresch vkresch self-assigned this Feb 18, 2020
@jdsika jdsika merged commit 5516268 into master Feb 19, 2020
@jdsika jdsika deleted the test-trace branch January 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality Quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants