Skip to content
This repository was archived by the owner on Jan 21, 2022. It is now read-only.

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Dec 5, 2019

Reference to a related issue in the repository

The PR which defines the new OSI file format and its benefits.

Add a description

What is this change?
This PR adds the feature for the osi visualizer to read and record OSI trace files in the new osi file format which is length separated.

Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
This PR is a feature and does not break any functionality and is still backwards compatible since the old txt separated by $$__$$ trace files can still be read. The recording will always output the OSI trace format to motivate user to use the new file format.

How has it been tested?
The functionality has been tested with multiple txt and osi trace files. The output of the recording has been used again as a input to see if the visualizer recognizes the format.

Change notes:

  • Extended input files to *.txt and *.osi
  • Added two functions (read_bytes, realloc_buffer) for reading and allocating in the new file format
  • Recorder export outputs now only to *.osi
  • Removed OSMP from gitmodule
  • Simplyfiction of some expression like if(var==true) --> if(var)
  • Changed nanoseconds and slidervalue to uint64_t
  • replaced push_back(std::make_pair( with emplace_back(

Mention a member

@jdsika @pmai let me know your thoughts, suggestions and improvements! Thanks ;)

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@vkresch vkresch added the quality Quality improvements. label Dec 5, 2019
@jdsika jdsika merged commit b57125f into master Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

quality Quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants