This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
The PR which defines the new OSI file format and its benefits.
Add a description
What is this change?
This PR adds the feature for the osi visualizer to read and record OSI trace files in the new osi file format which is length separated.
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?$$__$$ trace files can still be read. The recording will always output the OSI trace format to motivate user to use the new file format.
This PR is a feature and does not break any functionality and is still backwards compatible since the old txt separated by
How has it been tested?
The functionality has been tested with multiple txt and osi trace files. The output of the recording has been used again as a input to see if the visualizer recognizes the format.
Change notes:
read_bytes,realloc_buffer) for reading and allocating in the new file formatif(var==true)-->if(var)push_back(std::make_pair(withemplace_back(Mention a member
@jdsika @pmai let me know your thoughts, suggestions and improvements! Thanks ;)
Check the checklist