extend / shorten line range in change reco dialog#5519
Merged
MSoeb merged 10 commits intoOpenSlides:mainfrom Nov 7, 2025
Merged
extend / shorten line range in change reco dialog#5519MSoeb merged 10 commits intoOpenSlides:mainfrom
MSoeb merged 10 commits intoOpenSlides:mainfrom
Conversation
Without validators for line_from and line_to.
Member
Author
|
The following validators need to be added to the line_from and line_to field in the dialog.
|
If someone extends the line number above the existing lines, this will else lead to an inconsistence.
Member
Author
|
Added a validator for collides and max line range. |
Elblinator
requested changes
Oct 24, 2025
Member
Elblinator
left a comment
Elblinator
left a comment
There was a problem hiding this comment.
If I try to create a change ercomendation no dialog and following Error in console:
motion-change-recommendation-dialog.service.ts:33 ERROR TypeError: Cannot read properties of null (reading 'motion')
at _MotionChangeRecommendationControllerService.checkLineRanges
Member
Author
|
Yes, I could repro it. Only show edit buttons in editReco mode and fixed the validator for newReco mode. |
Member
Author
|
Creating and editing a ch reco should work now. |
Elblinator
approved these changes
Oct 28, 2025
Member
Elblinator
left a comment
Elblinator
left a comment
There was a problem hiding this comment.
I will assign @MSoeb for beauty testing etc.
bastianjoel
approved these changes
Oct 29, 2025
| /** | ||
| * Check if can use new line_from and line_to for recoId | ||
| */ | ||
|
|
Comment on lines
+105
to
+107
| } else { | ||
| return !intersect; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } else { | |
| return !intersect; | |
| } | |
| } | |
| return !intersect; |
| <mat-error>{{ 'Line range is not allowed to collide.' }}</mat-error> | ||
| } | ||
| </mat-form-field> | ||
| <mat-form-field [style.width.px]="300"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #5419
Without validators for line_from and line_to.
Needs: OpenSlides/openslides-backend#3170