183 create a load geometry from yaml function for vortexstepmethodjl and run on a simple wing #200
Conversation
…r V3 Kite, and adjusting plotting script to handle arbitrary column sorting of literature input
…indTunnel Data and Python
…xstepmethodjl-and-run-on-a-simple-wing' of github.com:OpenSourceAWE/VortexStepMethod.jl into 183-create-a-load_geometry_from_yaml-function-for-vortexstepmethodjl-and-run-on-a-simple-wing
…n-for-vortexstepmethodjl-and-run-on-a-simple-wing
There was a problem hiding this comment.
Pull Request Overview
This PR implements a YAML-based geometry loading function for VortexStepMethod.jl by updating configuration files and adding required dependencies. The change simplifies the geometry file structure by removing bridle-related data and updates the reference to use a cleaner geometry file.
- Updated geometry file reference in VSM settings from wing_geometry_polars_CFD.yaml to aero_geometry.yaml
- Cleaned up aero_geometry.yaml by removing bridle nodes, lines, and connections data
- Added YAML and PrettyTables dependencies to the manifest
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| data/TUDELFT_V3_KITE/vsm_settings.yaml | Updated geometry file reference to point to simplified aero_geometry.yaml |
| data/TUDELFT_V3_KITE/aero_geometry.yaml | Removed bridle-related configuration data, keeping only wing airfoil definitions |
| Manifest-v1.11.toml.default | Added YAML and PrettyTables package dependencies for geometry loading functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| wings: | ||
| - name: V3_Kite # Wing identifier for output labeling | ||
| geometry_file: data/TUDELFT_V3_KITE/wing_geometry_polars_CFD.yaml | ||
| geometry_file: data/TUDELFT_V3_KITE/aero_geometry.yaml |
There was a problem hiding this comment.
I would remove the "data" prefix, all yaml files are in the data dir
There was a problem hiding this comment.
But I will still approve this PR, as this is not important
No description provided.