-
Notifications
You must be signed in to change notification settings - Fork 0
183 create a load geometry from yaml function for vortexstepmethodjl and run on a simple wing #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
1-Bart-1
merged 31 commits into
main
from
183-create-a-load_geometry_from_yaml-function-for-vortexstepmethodjl-and-run-on-a-simple-wing
Oct 7, 2025
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
09119bc
adding a pyramid_model, initial commit
jellepoland a0d9977
#183 testing commit
jellepoland f9c7c80
#185, this commit/issue number work?
jellepoland 1ba7681
#185 Create rectangular wing from yaml and plot, using csv polar input
jellepoland b08dd6e
#185
jellepoland 420017d
#185 V3 kite runs, but results are yet not accurate
jellepoland 60ef204
#185 setting standard printing to false, adding literature results fo…
jellepoland e4ffc41
#185 non-italic subscripts in plotting
jellepoland cffe014
#185 , #186 : cleaned-up yaml_geometry, added a comparison to CFD - W…
jellepoland 4d07971
#155 V3_kite example now creates wing and solver from VSMSettings
jellepoland dd659ca
#155 adjusted V3_kite, to be specified from a .yaml
jellepoland 8942409
#155 working, with Wing constructor
jellepoland af11c40
#155 #185 added StructMapping for yaml parsing
jellepoland 5e56cc3
#185 #155 created ram_air_kite folder, all tests passing
jellepoland 29f372d
#185 adding a working pyramid model example
jellepoland 8da0fde
#185, #186 added test_yaml_geometry
jellepoland bcb06ff
#186 working on test folder
jellepoland a26ec1e
#186 passing all tests now!
jellepoland 38f9105
# 186 Adding random to toml
jellepoland c36f5e6
Update manifest
1-Bart-1 1510f6b
More versions
1-Bart-1 90ff624
#186 test passing without errors/warnings
jellepoland 298062d
#186 attempt at resolving windows issues
jellepoland 6d2e64a
Update docstring
1-Bart-1 3b1e431
Remove unused files
1-Bart-1 10e1d5d
#186 updated NEWS.md
jellepoland 7e7ae86
Merge branch '183-create-a-load_geometry_from_yaml-function-for-vorte…
jellepoland c9f2031
Merge branch 'main' into 183-create-a-load_geometry_from_yaml-functio…
jellepoland 81bff7a
#196 adding aero_geometry yaml
jellepoland cae7185
Update Manifest-v1.11.toml.default
jellepoland d349654
Update Manifest-v1.11.toml.default
jellepoland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the "data" prefix, all yaml files are in the data dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I will still approve this PR, as this is not important