Add examples using ControlPlots without copying examples#220
Merged
Add examples using ControlPlots without copying examples#220
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ControlPlots-based examples entry point without duplicating the existing examples, refactors shared plotting/polar helpers, and updates docs/installation/test tooling to support the new workflow.
Changes:
- Introduce
examples_cp/project +menu_cp.jl, and wire it into install/launch tooling. - Factor out shared polar/literature parsing and reuse it from both Makie and ControlPlots extensions (including optional moment plotting).
- Update examples/docs/tests to be backend-agnostic (except
menu.jlloading GLMakie) and run examples viamenu.jl --run-all.
Reviewed changes
Copilot reviewed 32 out of 37 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_setup.sh | Adjusts CI setup checks and runs examples via menu.jl --run-all. |
| test/plotting/test_plotting.jl | Expands plotting tests (show_plot dispatch, distributed inflow, literature parsing, moments). |
| test/Project.toml | Adds DelimitedFiles to support new test cases. |
| test/Aqua.jl | Tweaks Aqua config for Windows persistent task check. |
| src/wing_geometry.jl | Uses isequal for distribution comparisons; tightens aero-data interpolation validation. |
| src/solver.jl | Docstring clarification for vector component indices and return format. |
| src/settings.jl | Docstring unit formatting and minor type reference tweak. |
| src/plotting_helpers.jl | New shared helpers for literature parsing + polar generation. |
| src/VortexStepMethod.jl | Includes the new plotting helpers module file. |
| scripts/build_docu.jl | Simplifies docs dev script to activate docs environment before servedocs. |
| ext/VortexStepMethodMakieExt.jl | Tightens save_plot/show_plot signatures; reuses shared helpers; adds optional moments plotting. |
| ext/VortexStepMethodControlPlotsExt.jl | Improves save/geometry robustness; reuses shared helpers; adds optional moments plotting; label handling improvements. |
| examples_cp/menu_cp.jl | New ControlPlots menu/runner pointing at the existing examples/ scripts. |
| examples_cp/Project.toml | New environment for ControlPlots examples. |
| examples/stall_model.jl | Updates plotting calls to new layout/flows and backend-agnostic usage. |
| examples/rectangular_wing.jl | Removes GLMakie coupling; splits combined plotting into geometry/distribution/polars. |
| examples/ram_air_kite.jl | Removes GLMakie coupling; updates plotting calls and formatting. |
| examples/pyramid_model.jl | Removes GLMakie coupling; updates plotting calls and formatting. |
| examples/menu.jl | Adds --run-all mode and centralizes example list; keeps GLMakie load in menu. |
| examples/billowing.jl | Removes GLMakie coupling; updates plotting calls; enables moments in polars. |
| examples/bench.jl | Removes GLMakie coupling; minor formatting/timing comment update. |
| examples/V3_kite.jl | Removes GLMakie coupling; updates plotting calls; enables moments; refactors solver comparisons. |
| examples/Project.toml | Drops ControlPlots dep from the main examples environment. |
| docs/src/index.md | Updates installation/dev instructions and menu entry points (menu() / menu_cp()). |
| docs/src/examples.md | Updates example walkthrough formatting and mentions ControlPlots menu. |
| data/ram_air_kite/ram_air_kite_foil_cm_polar.csv | Removes generated polar CSV from repo. |
| data/ram_air_kite/ram_air_kite_foil_cl_polar.csv | Removes generated polar CSV from repo. |
| data/ram_air_kite/ram_air_kite_foil_cd_polar.csv | Removes generated polar CSV from repo. |
| bin/run_julia | Adds menu_cp() helper for quick launching ControlPlots menu. |
| bin/jetls_examples | Instantiates examples_cp and checks it with JETLS. |
| bin/install | Ensures manifests are copied for 1.11/1.12; instantiates/precompiles examples_cp; warms both plotting extensions. |
| README.md | Updates install/run instructions; adds ControlPlots menu entry point; fixes example snippet. |
| Project.toml | Adds examples_cp to workspace; updates compat for RecursiveArrayTools and SciMLBase. |
| Manifest-v1.12.toml.default | Updates lockfile hash/deps due to dependency/compat changes. |
| Manifest-v1.11.toml.default | Updates lockfile hash/deps due to dependency/compat changes. |
| .markdownlint.json | Adds markdownlint config to relax/standardize markdown formatting checks. |
| .gitignore | Adds ignores for generated results and removed/generated ram-air polar CSVs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ufechner7
requested changes
Apr 18, 2026
Member
ufechner7
left a comment
There was a problem hiding this comment.
Please, fix the GitHub Copilot comments.
6 tasks
ufechner7
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.