add test suite results and improved table formatting#80
Merged
Conversation
Compatibility processing - reformat compatibility message (remove colour coding of text) - In addition to recognizing .sbml and .sedml files as SBML and SED-ML format, .xml files with 'sedml' + 'sbml' or 'sbml' but not 'sedml' in their filename are recognized as SBML and SED-ML files. Other file types are not recognized but this can be extended in the future. - Instead of ❌ FAIL, unrecognized filetypes will marked as ❓UNSURE (this hasn't happened so far). At the moment all engines that do not support SBML/SED-ML are still marked as⚠ XFAIL. Test suite - Updated the results table of case 00001 - Added a table of case 01186 (steady state Flux Balance Analysis) Add back foldout menu in Engines column (went lost with the previous PR when the engine names were reformated)
stellaprins
requested review from
pgleeson,
robertvi and
sanjayankur31
and removed request for
robertvi
Collaborator
Author
|
@sanjayankur31 @pgleeson thanks for flagging up the column with unexpected fails in one of the |
Member
|
Great, thanks @stellaprins! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility processing
Test suite
Add back foldout menu in Engines column (went lost with the previous PR when the engine names were reformated)