Merged
Conversation
* improve file compatibility check * improve handling of engine_list input and make it possible to modify SED-ML files without them being overwritten (use_original_files) * update BIOMD0000000001 SED-ML and plot (x log scale) * update BIOMD0000000001 jsons and add BIOMD0000000138 table and plots with modified x limit * update plots and SED-ML files in attempt to replicate curated figures * increase max_wait_time to 600 seconds and update results tables and plots * Update test_biomodels_compatibility_biosimulators.py * bug fix (copy from temp files if files don't exist) * fix typo compatibe -> compatible
* add fbc attribute if missing * remove temp omex files and add 0001 to test suite cases * first check whether m == None before getting m.span() and improve clarity of add_xmlns_fbc_attribute documentation * remove unnecessary 'else:' in add_xmlns_fbc_attribute
* add fbc attribute if missing * improve compatibility messages and update tables * update results table SBML example
* Remove commented-out get_filetypes function from utils * Remove unused imports * Remove unused variables
* Draft biomodels tables * improve file compatibility check * improve handling of engine_list input and make it possible to modify SED-ML files without them being overwritten (use_original_files) * update BIOMD0000000001 SED-ML and plot (x log scale) * update BIOMD0000000001 jsons and add BIOMD0000000138 table and plots with modified x limit * update plots and SED-ML files in attempt to replicate curated figures * increase max_wait_time to 600 seconds and update results tables and plots * remove spaces from omex filenames before submitting to docker * add BIOMD0000001077 * add BIOMD0000000724 * only remove omex_file if it exists in __init__.py * add ValueError to remove_spaces_from_filename if dir contains spaces. Put unix command between single quotes. * fix temp SED-ML file handling bug in add_xmlns_sbml_attribute and add_xmlns_fbc_attribute * tweak XFAIL message and update plots and tables
stellaprins
requested review from
pgleeson,
robertvi and
sanjayankur31
and removed request for
robertvi
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.