Docs: explain AggregationLevel / problem types - #693
Merged
janosg merged 7 commits intoAug 3, 2026
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
janosg
reviewed
Aug 2, 2026
Clarify that all marked problems can use scalar optimizers, and link error-handling and estimagic docs.
for more information, see https://pre-commit.ci
janosg
reviewed
Aug 2, 2026
janosg
reviewed
Aug 3, 2026
janosg
approved these changes
Aug 3, 2026
janosg
left a comment
janosg
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I made one tiny change and will merge it soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AggregationLevel)@om.mark.*decorator expects as a return value, and maximize vs minimize for likelihoodCloses #595
Test plan
AggregationLevel)AggregationLevel) in the docs #595 (purpose of marks, return types, likelihood sign)