ENH: support SciPy-style callback(xk) during optimization - #697
Open
Pragati5-DEBUG wants to merge 1 commit into
Open
ENH: support SciPy-style callback(xk) during optimization#697Pragati5-DEBUG wants to merge 1 commit into
Pragati5-DEBUG wants to merge 1 commit into
Conversation
Pass callback through to InternalOptimizationProblem and invoke it on objective evaluations so it works for all optimizers.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callback(xk)inminimize/maximizeInternalOptimizationProblemand call it on objective evaluations (works for all optimizers, not via SciPy's own callback)callback(intermediate_result)left for a follow-upTest plan
pytest tests/optimagic/optimization/test_scipy_aliases.py::test_callback_xk_is_called