Fix to formatting for scroll-behavior file.#480
Merged
paramsiddharth merged 4 commits intomainfrom Feb 5, 2023
Merged
Conversation
2 tasks
DietBepis1
requested changes
Feb 4, 2023
smgraywood
commented
Feb 4, 2023
Contributor
Author
smgraywood
left a comment
smgraywood
left a comment
There was a problem hiding this comment.
Code and accompanying import have been deleted.
DietBepis1
approved these changes
Feb 4, 2023
paramsiddharth
approved these changes
Feb 5, 2023
Member
paramsiddharth
left a comment
paramsiddharth
left a comment
There was a problem hiding this comment.
Looks good to me. ✨ Well done!
Contributor
Author
Thank you! It looks like I don't have merge permissions, will this be merged by a maintainer? |
Member
Yes, Sarah. :) Let me merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
"Currently, when a page is taller than a device's viewport, if a user navigates to another page (i.e. home to campaign, etc.) the viewport will remain at the coordinates of the previous page."
Fix
Creation of scroll-behavior file and implementation in index file in router. Page now reverts to 0, 0 upon navigation to new page.