Skip to content

Fix : Free Tickets#48

Merged
ahegyes merged 4 commits intoOpenSourceOrg:developfrom
Vrishabhsk:fix/VJ-36-weird-chars
Jan 25, 2024
Merged

Fix : Free Tickets#48
ahegyes merged 4 commits intoOpenSourceOrg:developfrom
Vrishabhsk:fix/VJ-36-weird-chars

Conversation

@Vrishabhsk
Copy link
Copy Markdown
Contributor

@Vrishabhsk Vrishabhsk commented Jan 24, 2024

Issue

Fixes proposed

  • When setting the ticket price, if the price is 0, it should be set to 0.0 else the weird characters appear
  • This is the default functionality of the Sugar Calendar plugin Util functions
  • Replace $0.0 Per Ticket with Free Event
  • Replace Get a Ticket button text with Register

Preview

Screenshot 2024-01-19 at 4 21 22 PM

@Vrishabhsk
Replace $0.0 Per Ticket with Free Event
f7efcd0
@Vrishabhsk
Modified sugar-calendar functions
127ab20 
Added a default_sc_event_metadata filter callback to handle the default value of the ticket price. Text in button now modified by se_et_purchase_button_html filter. Usage of sprintf to handle future compatibility for ticket price text replacement
@Vrishabhsk
Fix conditional
ce1656b
@Vrishabhsk
Fix PHPCS
fa03320
@ahegyes ahegyes merged commit 9de9460 into OpenSourceOrg:develop Jan 25, 2024
@ahegyes ahegyes mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vrishabhsk @ahegyes