Skip to content

Make small/large cardinal direction a radio button#205

Merged
WeirdRubberDuck merged 3 commits intomasterfrom
issue/3754-cardinal-radio-buttons
Mar 19, 2026
Merged

Make small/large cardinal direction a radio button#205
WeirdRubberDuck merged 3 commits intomasterfrom
issue/3754-cardinal-radio-buttons

Conversation

@WeirdRubberDuck
Copy link
Collaborator

@WeirdRubberDuck WeirdRubberDuck commented Mar 17, 2026

Minimal change to use radial buttons rather than checkboxes. The code should probably be looked over again as part of refactoring the layouting of this panel (OpenSpace/OpenSpace#3753)

Closes OpenSpace/OpenSpace#3754

The behavior is still a little weird/unpredictable, as switching the radio buttons also disables the "Marks" checkbox if enabled

2026-03-17.11-45-36.mov

Copy link
Member

@alexanderbock alexanderbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the marks get disabled? If it is because its a radio button now, many the marks could stay a checkbox?

Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
@WeirdRubberDuck
Copy link
Collaborator Author

Why do the marks get disabled? If it is because its a radio button now, many the marks could stay a checkbox?

The behavior is unchanged from before. The issue is that there are four different textures - one with large/small letters and with/without lines each. The texture used dictates which radio buttons and checkboxes are enabled, and when clicking one of the radio buttons the texture without lines/marks are enabled.

I guess I could possibly update this here as well, but keeping a state for the marks checkbox and more explicitly control which precise texture is applied 🤔

@WeirdRubberDuck
Copy link
Collaborator Author

Merging this and leaving any future updates to OpenSpace/OpenSpace#3753

@WeirdRubberDuck WeirdRubberDuck merged commit 81eb14b into master Mar 19, 2026
1 check passed
@WeirdRubberDuck WeirdRubberDuck deleted the issue/3754-cardinal-radio-buttons branch March 19, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NightSky Panel: Cardinal Directions buttons should be radio buttons

2 participants