Make small/large cardinal direction a radio button#205
Make small/large cardinal direction a radio button#205WeirdRubberDuck merged 3 commits intomasterfrom
Conversation
alexanderbock
left a comment
There was a problem hiding this comment.
Why do the marks get disabled? If it is because its a radio button now, many the marks could stay a checkbox?
src/panels/NightSkyPanel/tabs/MarkingsTab/CardinalDirectionsBoxes.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
The behavior is unchanged from before. The issue is that there are four different textures - one with large/small letters and with/without lines each. The texture used dictates which radio buttons and checkboxes are enabled, and when clicking one of the radio buttons the texture without lines/marks are enabled. I guess I could possibly update this here as well, but keeping a state for the marks checkbox and more explicitly control which precise texture is applied 🤔 |
|
Merging this and leaving any future updates to OpenSpace/OpenSpace#3753 |
Minimal change to use radial buttons rather than checkboxes. The code should probably be looked over again as part of refactoring the layouting of this panel (OpenSpace/OpenSpace#3753)
Closes OpenSpace/OpenSpace#3754
The behavior is still a little weird/unpredictable, as switching the radio buttons also disables the "Marks" checkbox if enabled
2026-03-17.11-45-36.mov