Skip to content

new email flow#13

Merged
smarcet merged 1 commit intomainfrom
feature/manual-incomplete-registration-reminder
Feb 23, 2022
Merged

new email flow#13
smarcet merged 1 commit intomainfrom
feature/manual-incomplete-registration-reminder

Conversation

@romanetar
Copy link
Collaborator

@smarcet
Copy link
Collaborator

smarcet commented Feb 18, 2022

@romanetar we need to create another migration to seed the new event activity on all sumits
check here
https://github.com/OpenStackweb/summit-api/blob/main/database/migrations/model/Version20220207195617.php
and also u need to add the new email activity to seeders
https://github.com/OpenStackweb/summit-api/blob/main/database/seeders/SummitEmailFlowTypeSeeder.php
regards

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review comments

@romanetar romanetar force-pushed the feature/manual-incomplete-registration-reminder branch from 0a2fe2d to b8ae13b Compare February 18, 2022 12:52
@romanetar
Copy link
Collaborator Author

@smarcet commit amended

@smarcet smarcet self-requested a review February 23, 2022 14:04
@smarcet
Copy link
Collaborator

smarcet commented Feb 23, 2022

@romanetar please add here the missing email template

SummitAttendeeTicketRegenerateHashEmail::EVENT_SLUG,

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review comments

Signed-off-by: romanetar <roman_ag@hotmail.com>
@romanetar romanetar force-pushed the feature/manual-incomplete-registration-reminder branch from b8ae13b to 7e9ef35 Compare February 23, 2022 14:28
@romanetar
Copy link
Collaborator Author

@smarcet commit amended

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@smarcet smarcet merged commit 4a495d6 into main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants