Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeTypeApiController
#407
+761
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasperrone-exo
added
the
documentation
caseylocker
requested changes
Nov 29, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo quick fix for x: parameter key name.
All 11 endpoints use 'authz_groups' instead of the standard 'required-groups':
x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],
Contributor
Author
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
approved these changes
Dec 3, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
LGTM. @smarcet if you agree please merge.
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitbadgetypeapicontroller
branch
from
c35a66d to
6689bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh7z