[Audit][Medium] InputSettings.saveFromMapper silently swallows errors from persistence.save

[MichaelFisher1997]

🔍 Module Scanned\n (automated audit scan)\n\n## 📝 Summary\nThe function creates a temporary instance and attempts to save settings to disk, but uses to silently swallow any errors from . This means disk full errors, permission errors, or any other I/O failures during save go completely undetected, and the user receives no feedback about why their settings weren't persisted.\n\n\n## 📍 Location\n- File: \n- Function/Scope: \n\n\n## 🔴 Severity: Medium\n- Critical: N/A\n- High: N/A \n- Medium: Silent error swallowing means failed saves go undetected with no user feedback\n- Low: N/A\n\n## 💥 Impact\nWhen is called (e.g., via at app shutdown or when saving input bindings), if the settings file cannot be written due to disk full, permissions, or other I/O errors, the error is silently discarded. Users may believe their settings were saved when they were not, leading to:\n- Lost custom keybindings on next launch\n- Lost input configuration changes\n- Confusion about why settings reverted\n\n## 🔎 Evidence\n\n\nThe caller in :\n\n\nNotice that properly logs errors from input settings save via . However, itself swallows errors internally with before returning, so always receives and never logs anything.\n\n## 🛠️ Proposed Fix\nRemove the and let errors propagate to the caller:\n\n\n\nThis way the caller () receives the error and can properly log it.\n\n## ✅ Acceptance Criteria\n- [ ] propagates errors from to its caller\n- [ ] receives and logs errors when input settings save fails\n- [ ] No empty blocks in the save path\n- [ ] passes\n\n## 📚 References\n- Zig error handling pattern: https://ziglang.org/documentation/0.16/#Error-Handling\n- - caller that properly handles errors but is bypassed by internal

[github-actions]

Bug Classification: Bug (but with incorrect analysis)

The audit report incorrectly identifies the error-swallowing location. Here's the accurate analysis:

What the code actually does:

1. saveFromMapper (line 147-158) calls try settings.save() — this is InputSettings.save() (line 123) which properly propagates errors via !void return type.

2. The callers properly catch errors:

   • app.zig:304-306 catches and logs via errWithTrace
   • screen.zig:176-178 catches and logs via log.err

3. Actual issue exists elsewhere: persistence.save() (line 110 in settings/persistence.zig) is a void function that logs warnings instead of propagating errors. But this is a separate function — it saves game settings, not input settings.

The audit appears to conflate two different save paths:

• InputSettings.save() — returns !void, errors propagate correctly
• Settings.persistence.save() — returns void, swallows errors internally

Correct sub-issues if this warrants investigation:

1. InputSettings.saveFromMapper — no bug found; errors propagate correctly
2. SettingsManager.persistence.save (void return) — legitimate concern: errors are logged but not propagated to callers like App.saveAllSettings at app.zig:303 which has no error handling

The automated-audit label is appropriate, but the specific claim about saveFromMapper is inaccurate based on the current codebase state.

opencode session  |  github run