18 shadow tests added, all 648 tests pass#447
Closed
github-actions[bot] wants to merge 1 commit intodevfrom
Closed
18 shadow tests added, all 648 tests pass#447github-actions[bot] wants to merge 1 commit intodevfrom
github-actions[bot] wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done. Created
src/engine/graphics/shadow_tests.zigwith 18 tests covering:Tests Added:
ShadowCascades.initZero creates identity matrices and zero arraysShadowCascades.isValid returns true for properly initialized cascadesShadowCascades.isValid returns false for non-increasing splitsShadowCascades.isValid returns false for non-positive texel sizeShadowCascades.isValid returns false for NaN in splitsShadowCascades.isValid returns false for NaN in texel sizescomputeCascades returns zero cascades for resolution == 0computeCascades returns zero cascades for far <= nearcomputeCascades returns zero cascades for near <= 0computeCascades uses fixed splits for large shadow distance (>500)computeCascades uses logarithmic splits for small shadow distance (<=500)ShadowConfig default valuesShadowParams struct layout and defaultsIShadowScene interface delegationCASCADE_COUNT is 4getShadowMapHandle returns 0 for out-of-bounds cascade indexvalidateCascades returns true for valid cascadesvalidateCascades returns false for invalid cascadesAll 648 tests pass. The warning "Invalid shadow cascade data detected:" is expected behavior from
validateCascadeswhen testing with invalid input.Triggered by scheduled workflow
opencode session | github run