Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 31.14% 31.14%
=======================================
Files 71 71
Lines 2630 2630
=======================================
Hits 819 819
Misses 1811 1811
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Introduces a new shim mode that targets ByteDance’s DanceUIGraph backend, allowing OpenAttributeGraphShims to be built against a different attribute-graph implementation. Changes:
Technical Notes: The DanceUIGraph shim mode links 🤖 Was this summary useful? React with 👍 or 👎 |
| base.invalidate() | ||
| } | ||
|
|
||
| public var index: UInt32 { |
There was a problem hiding this comment.
Sources/OpenAttributeGraphShims/Adapter/DanceUIGraph.swift:555: Subgraph.index’s getter always returns 0, so reading back an index after setting it will be incorrect and may break callers relying on stable subgraph indices. If DanceUIGraph doesn’t expose an index getter, consider making this write-only or documenting that reads are unsupported in this shim mode.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| self.init(Optional(attribute)) | ||
| } | ||
|
|
||
| public init(_details: Details) { |
There was a problem hiding this comment.
Sources/OpenAttributeGraphShims/Adapter/DanceUIGraph.swift:995: init(_details:) ignores seed, but Hashable/== are based on _details (including seed), so round-tripping AnyWeakAttribute(_details:) can change identity. This can also make instances reconstructed from stored Details compare unequal depending on base.subgraph_id.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| #if OPENATTRIBUTEGRAPH_DANCEUIGRAPH | ||
| extension AnyAttribute { | ||
| func _debugDescription(indent: Int) -> String { | ||
| "\(String(repeating: tab, count: indent))\(debugDescription)" |
There was a problem hiding this comment.
Sources/OpenAttributeGraphShims/Attribute+Debug.swift:28: In the DanceUIGraph branch, _debugDescription(indent:) only prefixes the first line of debugDescription, so multi-line base.debugDescription output won’t be indented consistently. This also changes the debug string format compared to other vendors, which may surprise callers relying on the structured output.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
No description provided.