Skip to content

Fix OPENSWIFTUI_SAFE_WRAPPER_IMP for class method #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix OPENSWIFTUI_SAFE_WRAPPER_IMP for class method #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Sources/OpenSwiftUI_SPI/Shims/OpenSwiftUIShims.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,20 @@ os_log_t openSwiftUIShimsLog(void);

#define OPENSWIFTUI_SHIMS_LOG_ERROR(fmt, ...) os_log_error(openSwiftUIShimsLog(), fmt, ##__VA_ARGS__)

// For a instance method, we need a class which can be access via [self class] or object_getClass(self).
// For a class method, we need the metaclass. [self class] will return the class itself. object_getClass(self) will return the metaclass.
// Alternatively, we can use objc_getMetaClass(class_getName([self class])) to get the metaclass.
// In summary:
// Always metaclass: Use `objc_getMetaClass(class_getName([self class]))`
// Always class: Use `[self class]`
// object_getClass(self) will return the class if self is an object and a metaclass if self is a class.

#define OPENSWIFTUI_SAFE_WRAPPER_IMP(ReturnType, SelectorName, DefaultReturnValue, ...) \
typedef ReturnType (*Func)(id, SEL, ##__VA_ARGS__); \
SEL selector = NSSelectorFromString(SelectorName); \
Func func = nil; \
if ([self respondsToSelector:selector]) { \
IMP impl = class_getMethodImplementation([self class], selector); \
IMP impl = class_getMethodImplementation(object_getClass(self), selector); \
func = (Func)impl; \
} else { \
OPENSWIFTUI_SHIMS_LOG_ERROR("%@ can't respond to selector %@", NSStringFromClass([self class]), NSStringFromSelector(selector)); \
Expand Down
Loading