Skip to content

Fix NSHostingView dealloc issue #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

Fix NSHostingView dealloc issue #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Sources/OpenSwiftUITestsSupport/Integration/PlatformHostingControllerHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ package func triggerLayoutWithWindow(
vc.triggerLayout()
window = vc.view.window
}
#if os(macOS)
window.isReleasedWhenClosed = false
window.close()
#endif
withExtendedLifetime(window) {}
}

Expand All @@ -57,6 +61,10 @@ package func triggerLayoutWithWindow(
vc.triggerLayout()
window = vc.view.window
}
#if os(macOS)
window.isReleasedWhenClosed = false
window.close()
#endif
withExtendedLifetime(window) {}
}

Expand All @@ -73,6 +81,10 @@ package func triggerLayoutWithWindow(
window = vc.view.window
}
}
#if os(macOS)
window.isReleasedWhenClosed = false
window.close()
#endif
withExtendedLifetime(window) {}
}

Expand All @@ -89,6 +101,10 @@ package func triggerLayoutWithWindow(
window = vc.view.window
}
}
#if os(macOS)
window.isReleasedWhenClosed = false
window.close()
#endif
withExtendedLifetime(window) {}
}

Expand Down
10 changes: 2 additions & 8 deletions ...CompatibilityTests/Modifier/ViewModifier/AppearanceActionModifierCompatibilityTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import Testing
import Foundation
import OpenSwiftUITestsSupport

@MainActor
struct AppearanceActionModifierCompatibilityTests {
Copy link

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @MainActor attribute was removed from this test struct. According to the coding guidelines, test structures should maintain proper isolation when dealing with UI components. Since this test involves appearance actions which typically require main actor isolation, consider whether this removal is intentional or if it might cause concurrency issues.

Copilot uses AI. Check for mistakes.
@Test
func appear() async throws {
Expand Down Expand Up @@ -70,12 +69,7 @@ struct AppearanceActionModifierCompatibilityTests {
)
)
}
#if os(macOS)
// FIXME: NSHostingView is not dealloc here
// See #454
#expect(Helper.result == "AAD")
#else
#expect(Helper.result == "AADD")
#endif

await #expect(Helper.result == "AADD")
Copy link

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The await keyword is used with #expect which is not an async function. This will cause a compilation error. Remove the await keyword.

Suggested change
await #expect(Helper.result == "AADD")
#expect(Helper.result == "AADD")

Copilot uses AI. Check for mistakes.
}
}